fast/css/crash-in-attachFirstLetterTextLayoutObjects.html failing on many platforms |
||
Issue descriptionhttps://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2Fcrash-in-attachFirstLetterTextLayoutObjects.html&testType=webkit_tests Some builds with the failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/3738 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.12/builds/1176 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/51520 The failure is due to a slight shift between expected and actual results, attaching diff.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7773939ef302371795ef39138e10225f3d493aa1 commit 7773939ef302371795ef39138e10225f3d493aa1 Author: foolip <foolip@chromium.org> Date: Thu Apr 06 10:18:46 2017 Revert of Clear pseudoElement from ElementRareData when FirstLetterPseudoElement doesn't have a LayoutObject (patchset #4 id:60001 of https://codereview.chromium.org/2752163003/ ) Reason for revert: The added test is failing on many platforms due to a mismatch between actual expected (not a crash). BUG= 708967 Original issue's description: > Clear pseudoElement from ElementRareData when FirstLetterPseudoElement doesn't have a LayoutObject > > This patch edits Element::rebuildPseudoElementLayoutTree() to make sure > it mirrors Element::updatePseudoElement() called in > Element::recaclStyle() by calling Element::updateFirstLetter() in the > case the PseudoElement is firstLetter as is done in > Element::updateFirstLetter() to ensure we don't call > Element::retachLayoutTree() uncoditionally. > > Adds crash test and expectation as well. > > BUG= 700655 > > Review-Url: https://codereview.chromium.org/2752163003 > Cr-Commit-Position: refs/heads/master@{#462373} > Committed: https://chromium.googlesource.com/chromium/src/+/6d202487ff823def4672599f51e9f13880e6b877 TBR=esprehn@chromium.org,nainar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 700655 Review-Url: https://codereview.chromium.org/2802993002 Cr-Commit-Position: refs/heads/master@{#462413} [delete] https://crrev.com/9e51d07999515ab5f8567ba8b446e316137eb0b8/third_party/WebKit/LayoutTests/fast/css/crash-in-attachFirstLetterTextLayoutObjects-expected.html [delete] https://crrev.com/9e51d07999515ab5f8567ba8b446e316137eb0b8/third_party/WebKit/LayoutTests/fast/css/crash-in-attachFirstLetterTextLayoutObjects.html [modify] https://crrev.com/7773939ef302371795ef39138e10225f3d493aa1/third_party/WebKit/Source/core/dom/Element.cpp
,
Apr 6 2017
Thank you for making the revert foolip@ :) Marking this issue as Fixed since you made the revert. And will reland the CL once I get an lgtm on the fixed up test. |
||
►
Sign in to add a comment |
||
Comment 1 by foolip@chromium.org
, Apr 6 2017