Don't use deprecated headers from WebRTC webrtc/video_{encoder,decoder}.h are moved to webrtc/api/video_codecs/) |
|||
Issue description
Feature description:
Eng owner:
Product owner:
webrtc/video_{encoder,decoder}.h have moved to webrtc/api/video_codecs/
All includes of the old files should be changed to new ones
,
Apr 6 2017
Can't you do it yourself? Updating headers in Chromium doesn't sound too hard (pretty much just search+replace). You don't need to be a Chromium committer to do so, you'll just use the CQ to land the change.
,
Apr 6 2017
Yes, I will do it. However I am confused. So far I found only one include in whole chromium codebase: https://cs.chromium.org/search/?q=webrtc/video_(encoder%7Cdecoder).h&type=cs Did I miss something?
,
Apr 6 2017
I don't know if there should be more uses. Maybe most uses were including the header files via other headers?
,
Apr 6 2017
Patch landed here: https://chromium.googlesource.com/chromium/src/+/8ce9edcf92537d6e0a8433a59d17c31f965ac498
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd6c74121796da3012155a89c16ada1332736a06 commit fd6c74121796da3012155a89c16ada1332736a06 Author: dalecurtis <dalecurtis@chromium.org> Date: Thu Apr 06 22:28:46 2017 Remove stale gn arg to avoid undeclared argument warning. v8_enable_inspector was removed recently. Clean up remnants. Also fixes a dependent gn check issue which blocked submission, http://crrev.com/462467 did not update GN deps for new header. BUG=645890, 708965 TEST=none Review-Url: https://codereview.chromium.org/2801123002 Cr-Commit-Position: refs/heads/master@{#462652} [modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/.gn [modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/content/test/BUILD.gn [modify] https://crrev.com/fd6c74121796da3012155a89c16ada1332736a06/ios/BUILD.gn |
|||
►
Sign in to add a comment |
|||
Comment 1 by ilnik@chromium.org
, Apr 6 2017