New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708960 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Apr 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dbeam@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary scrollbar bounce back is seen while navigating Reset section using “Side Nav”

Reported by abom...@etouch.net, Apr 6 2017 
Chrome Version:59.0.3064.0 (Official Build) d171113ba68ab33dc071c55d5c023d14328f453d-refs/heads/master@{#462305}
OS:Windows (7,8,10), Mac (10.11.6, 10.12.1), Linux (Ubuntu 14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings
2. Click on 'Side nav' menu icon and click on 'Advanced'
3. Click on 'Reset' option and observe.

Actual:Unnecessary scrollbar bounce back is seen (i.e.Page does not navigate to Reset section properly from side nav menu)
Expected:Scrollbar should not bounce back.(i.e.Page should properly navigate to Reset section properly from side nav menu)

This is regression issue. broken in ‘M 59’ and below is manual bisect info:
Good build:59.0.3063.0
Bad build:59.0.3064.0
Actual_reset.mov
2.6 MB Download
Exp_reset.mov
1.8 MB Download

Comment 1 by rbasuvula@chromium.org, Apr 6 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3063.0 (Revision:461928).
Bad build:59.0.3064.0 (Revision:462305).

You are probably looking for a change made after 462303 (known good), but no later than 462304 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/c198feadcc54ea92134df2dc3a5f4f390fcd9493..9b3c62205a0b13f99c59792b834f485b825e2cb8

From the CL above, assigning the issue to the concern owner

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2797353003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3064.0

Comment 2 by dpa...@chromium.org, Apr 6 2017

Cc: dbeam@chromium.org
Hm, the CL to focus settings-main when the sidebar is closed caused this regression. I am going to revert for now.

Comment 3 by dpa...@chromium.org, Apr 6 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3257e6eb48627fde7ad129012ee9904110e4969

commit c3257e6eb48627fde7ad129012ee9904110e4969
Author: dpapad <dpapad@chromium.org>
Date: Fri Apr 07 17:39:58 2017

MD Settings: Focus the container, instead of settings-main, when sidenav is closed.

This fixes a regression where the scroll position changed after closing the
sidenav, and is more correct, since the container is the scroll target.

BUG= 708960 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2802073002
Cr-Commit-Position: refs/heads/master@{#462913}

[modify] https://crrev.com/c3257e6eb48627fde7ad129012ee9904110e4969/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/c3257e6eb48627fde7ad129012ee9904110e4969/chrome/browser/resources/settings/settings_ui/settings_ui.js

Comment 5 by dpa...@chromium.org, Apr 7 2017

Status: Fixed (was: Started)

Comment 6 by dpa...@chromium.org, Apr 7 2017

Labels: Proj-MaterialDesign-WebUI

Comment 7 by msrchandra@chromium.org, Apr 11 2017 

Checked the issue on Latest Stable# 59.0.3067.6 on Windows and found the issue to be fixed.
Will update the issue on Mac and Linux once after the builds are available.
Thank You.

Comment 8 by msrchandra@chromium.org, Apr 11 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3067.0 TE-Verified-59.0.3067.6
Apologies for the typo in Comment# 7.
Tested the issue on Latest Dev# 59.0.3067.0 on windows and Latest Dev# 59.0.3067.0 on Mac & Linux and found the issue to be fixed.
Hence adding TE-Verified Labels accordingly.
Thank You.
►

Sign in to add a comment