New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708959 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Most Visited cell display when there is less than a full line

Project Member Reported by gambard@chromium.org, Apr 6 2017

Issue description

When the user has less than a full line of Most Visited tiles, they are displayed as if the line was full, using placeholders for the missing tiles on the line (screenshot attached).
I think this behavior can be changed as part of displaying new suggested content on the NTP.
WDYT?
 
Simulator Screen Shot Apr 6, 2017, 11.44.25 AM.png
56.4 KB View Download
Offline we discussed dropping the placeholders and centering the row of items horizontally, but for that particular solution I'm not fully convinced it is better.

Is there a particular reason you want to change this (maybe related to the content additions)?
I am completely rewriting this behavior, so if a change is needed, the new behavior would be as long to implement as the old one. It is a good opportunity to make a change if one is needed.
Don't these placeholders get backfilled on the next NTP ? Whether with popular sites or with most likely ? I am not sure when do we end up with a grey square like this.
I am not sure I understand. The placeholders appear when you have the popular sites and you delete some of them for example.
If you visit some pages, they get filled.
Cc: noyau@chromium.org
I see. My bad. So this case is only when the user hasn't visited enough sites yet, is signed out, and deletes some popular sites tiles. 

I think it is cleaner to not have anything at all personally. No grey squares and no change in layout. 
I am not sure the signed in/out change anything (the user would need to have not enough sites visited on all devices), but yes this should be the only use cases.
Talked with Gauthier offline and apparently this isn't a copy-and-paste type of reimplementation and the current grey cell behavior is a lot of work to redo. Considering Android doesn't use the grey cell behavior, you can remove it, but keep the layout as is (i.e. don't center <x cells).
Status: Fixed (was: Assigned)
Thanks, we go as pete said in #7.

Sign in to add a comment