Most Visited cell display when there is less than a full line |
|||
Issue descriptionWhen the user has less than a full line of Most Visited tiles, they are displayed as if the line was full, using placeholders for the missing tiles on the line (screenshot attached). I think this behavior can be changed as part of displaying new suggested content on the NTP. WDYT?
,
Apr 6 2017
I am completely rewriting this behavior, so if a change is needed, the new behavior would be as long to implement as the old one. It is a good opportunity to make a change if one is needed.
,
Apr 8 2017
Don't these placeholders get backfilled on the next NTP ? Whether with popular sites or with most likely ? I am not sure when do we end up with a grey square like this.
,
Apr 10 2017
I am not sure I understand. The placeholders appear when you have the popular sites and you delete some of them for example. If you visit some pages, they get filled.
,
Apr 10 2017
I see. My bad. So this case is only when the user hasn't visited enough sites yet, is signed out, and deletes some popular sites tiles. I think it is cleaner to not have anything at all personally. No grey squares and no change in layout.
,
Apr 10 2017
I am not sure the signed in/out change anything (the user would need to have not enough sites visited on all devices), but yes this should be the only use cases.
,
Apr 12 2017
Talked with Gauthier offline and apparently this isn't a copy-and-paste type of reimplementation and the current grey cell behavior is a lot of work to redo. Considering Android doesn't use the grey cell behavior, you can remove it, but keep the layout as is (i.e. don't center <x cells).
,
May 5 2017
Thanks, we go as pete said in #7. |
|||
►
Sign in to add a comment |
|||
Comment 1 by pschaffner@chromium.org
, Apr 6 2017