New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test fast/backgrounds/background-image-relative-url-in-iframe.html is flaky

Project Member Reported by yhirano@chromium.org, Apr 6 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51feb2d65333500aa71a395346b189a4fa65ee4c

commit 51feb2d65333500aa71a395346b189a4fa65ee4c
Author: yhirano <yhirano@chromium.org>
Date: Thu Apr 06 08:43:37 2017

Mark fast/backgrounds/background-image-relative-url-in-iframe.html as flaky

BUG= 708934 
NOTRY=true
TBR=rune@opera.com

Review-Url: https://codereview.chromium.org/2804953002
Cr-Commit-Position: refs/heads/master@{#462398}

[modify] https://crrev.com/51feb2d65333500aa71a395346b189a4fa65ee4c/third_party/WebKit/LayoutTests/TestExpectations

Components: -Blink>LayoutTests
Status: Available (was: Untriaged)
It might just not be loading the iframe in time for the pixel capture.
Labels: Update-Fortnightly
Cc: shoon....@lge.com

Comment 5 by suzyh@chromium.org, Apr 10 2017

I can't repro this locally; is there anything special about LayoutTests/fast that I should consider in looking into this?

I would consider adding <link rel=preload ...> to the start of the test to load the image ahead of time.
I see failures locally with --repeat 100.

Comment 7 by suzyh@chromium.org, Apr 10 2017

Owner: suzyh@chromium.org
Status: Assigned (was: Available)
D'oh, I either didn't do enough repeats, or I forgot to remove the line from TestExpectations.

Turns out the preload doesn't go in the main html file but inside what's set for the iframe's innerHTML. Uploaded https://codereview.chromium.org/2808013003 for review.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71abad621416fd3cbb69ebb2dae0d90b84be0287

commit 71abad621416fd3cbb69ebb2dae0d90b84be0287
Author: suzyh <suzyh@chromium.org>
Date: Tue Apr 18 08:32:43 2017

Deflake background-image-relative-url-in-iframe.html

Deflake LayoutTests/fast/backgrounds/ test
background-image-relative-url-in-iframe.html by delaying testRunner
completion until iframe load event fires.

iframe.contentDocument.body.innerHTML has been replaced with
iframe.srcdoc in order to cause the load event to retrigger.

BUG= 708934 

Review-Url: https://codereview.chromium.org/2808013003
Cr-Commit-Position: refs/heads/master@{#465176}

[modify] https://crrev.com/71abad621416fd3cbb69ebb2dae0d90b84be0287/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/71abad621416fd3cbb69ebb2dae0d90b84be0287/third_party/WebKit/LayoutTests/fast/backgrounds/background-image-relative-url-in-iframe.html

Comment 9 by suzyh@chromium.org, Apr 18 2017

Status: Fixed (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment