New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708932 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: The "CrOS Factory" in left side bar is split into two lines

Project Member Reported by hungte@chromium.org, Apr 6 2017

Issue description

In ToT, I often see in the left side bar, the title

 CrOS Factory [Switch to\nEnglish] PLAY_ICON TERMINAL_ICON

has been corrupted that "Factory" goes to the second line, making it hard to activate the main menu, or the first test item.

Not sure if that was caused by recent size changes in the "Switch to English" field. Maybe we should:

 1. Set CrOS Factory to with style write-space: nowrap;
 2. Replace Switch to English by some icon and make it pop a language selection list when clicked


 
Can't seems to reproduce this without manually dragging the middle separator to resize the left panel. Any idea on how to reproduce this?
Not sure, but I usually see this when I need to do fault analysis here.

Feel free to set this as low priority.
Stimim just showed me how to reproduce this:

 Boot factory UI without engineering mode
 Enable engineering mode
 The Terminal icon appears, and makes CrOS Factory too large to fit.
 
Project Member

Comment 4 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/999ae682a983f105c53a668eac58fd9b14495186

commit 999ae682a983f105c53a668eac58fd9b14495186
Author: Peter Shih <pihsun@chromium.org>
Date: Wed May 03 13:16:44 2017

goofy: Fix the min width of left pane too small.

The title of left panel can't fit in 275 pixels, and would cause the
"CrOS Factory" to be wrapped in two lines when the screen width is
not large enough.

BUG= chromium:708932 
TEST=manually

Change-Id: Ie738fe592d2349c73890f5b40fa3639536e46061
Reviewed-on: https://chromium-review.googlesource.com/494506
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/999ae682a983f105c53a668eac58fd9b14495186/py/goofy/js/goofy.js

Comment 5 by hungte@chromium.org, May 18 2017

Status: Fixed (was: Untriaged)

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment