compile failing on Android builders - conflict in CSSPropertyAPICounterIncrement.cpp |
||||
Issue descriptioncompile failing on 4 builders Builders failed on: - Android Builder: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder - Android Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29 - Android Clang Builder (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29 - Cast Android (dbg): https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29 ../../third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp:11:17: error: prototype for 'const blink::CSSValue* blink::CSSPropertyAPICounterIncrement::parseSingleValue(blink::CSSParserTokenRange&, const blink::CSSParserContext*)' does not match any in class 'blink::CSSPropertyAPICounterIncrement' const CSSValue* CSSPropertyAPICounterIncrement::parseSingleValue( ^ In file included from ../../third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp:5:0: gen/blink/core/css/properties/CSSPropertyAPICounterIncrement.h:18:26: error: candidate is: static const blink::CSSValue* blink::CSSPropertyAPICounterIncrement::parseSingleValue(blink::CSSParserTokenRange&, const blink::CSSParserContext&) static const CSSValue* parseSingleValue(CSSParserTokenRange&, const CSSParserContext&); Assigning to myself until build is green again
,
Apr 6 2017
ALso i note the finditforme bot has reverted this CL: https://codereview.chromium.org/2786153004 Both reverts are in the new build building at https://uberchromegw.corp.google.com/i/chromium/builders/Android/builds/70750 .. let's hope it still compiles!
,
Apr 6 2017
Hm the autorevert seems to have fixed it so my revert was probably unnecessary - eg. https://build.chromium.org/p/chromium.linux/builders/Cast%20Android%20%28dbg%29/builds/69193
,
Apr 6 2017
It's back to green so I guess the original CLs just need to be relanded in the right order.
,
Apr 6 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by awdf@chromium.org
, Apr 6 2017