New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 750935
issue 752213



Sign in to add a comment

event_mon uses a service account in the chrome-infra-mon-proxy cloud project

Project Member Reported by dsansome@chromium.org, Apr 6 2017

Issue description

I discovered this after I deleted the chrome-infra-mon-proxy cloud project and event_mon stopped working.

It's the helpfully named "Service account 2": 553440471104-s7tqmturddp59r4ekl28luqajr88sbo0@developer.gserviceaccount.com.  pgervais added it in https://chromereviews.googleplex.com/192647014

event_mon isn't related to chrome-infra-mon-proxy, so it shouldn't be using a service account from it.

Question: is a credential even required to send to the endpoint (https://play.googleapis.com/log)?  In Issue 471433 pgervais says "This is implemented and deployed, only the server-side part remains.", which seems to imply that the server isn't checking credentials at all.
 
Unless someone fixed it, it is correct that the server isn't checking any
credentials at that point. So credentials are not required to send events
to the endpoint.

That said, I do believe it's necessary to have authentication here to avoid
spoofing. Checking for authentication is easy to implement, I simply did
not get to it.
Cc: katthomas@chromium.org
Thanks Philippe!  I appreciate you helping out long after you've left the team :)

I don't really know much about the server-side parts of event_mon.  Can you add some details to issue 471433?  Like, where the code is, where it runs, which team owns it, and how it's deployed.
From a private thread, the action item is to remove the authentication from requests. We expect to remove the Clearcut pipeline from event_mon in favor of BigQuery soon.

Cc: -pgervais@chromium.org sergeybe...@chromium.org
Owner: dsansome@chromium.org
Sorry, I don't have time to take on this in the immediate future. Dave, back to you for finding a better owner.
Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/b2ff936cd06c4d01033477dbbb12a0d88f244583

commit b2ff936cd06c4d01033477dbbb12a0d88f244583
Author: David Sansome <dsansome@google.com>
Date: Wed May 03 23:40:40 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Jun 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/466ecf749887b37e4c13ebc8b158eb4e7f92937a

commit 466ecf749887b37e4c13ebc8b158eb4e7f92937a
Author: David Sansome <dsansome@chromium.org>
Date: Fri Jun 09 03:47:37 2017

Remove some deprecated flags from event_mon

Bug:  708920 
Change-Id: I2d68b9a885e16707f683b159a6ff73ccda11dcb5
Reviewed-on: https://chromium-review.googlesource.com/527753
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/466ecf749887b37e4c13ebc8b158eb4e7f92937a/packages/infra_libs/infra_libs/event_mon/config.py

Status: Fixed (was: Assigned)
Blocking: 752213 750935
Status: Assigned (was: Fixed)
What is this?  It's blocking me rotating creds now... can I remove it?
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/1c568f266f50e0508047805100372a7c2cad8383

commit 1c568f266f50e0508047805100372a7c2cad8383
Author: Elliott Friedman <friedman@google.com>
Date: Fri Aug 04 18:24:32 2017

Owner: friedman@chromium.org
Status: Fixed (was: Assigned)
I think event-mon is gone now...

Sign in to add a comment