New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html is flaky due to race between test and DOMContentLoaded

Project Member Reported by foolip@chromium.org, Apr 6 2017

Issue description

There are failures on both WebKit Mac10.11 (dbg) and WebKit Win7 (dbg):
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=canvas-lose-restore-googol-size.html

For both, the expected vs. actual diff looks like this:
@@ -11,13 +11,13 @@
 PASS ctx.isContextLost() is true
 PASS contextLostTest is true
 PASS ctx.isContextLost() is true
-PASS successfullyParsed is true
-
-TEST COMPLETE
 PASS Graphics context lost event dispatched.
 PASS contextLostTest is true
 PASS ctx.isContextLost() is true
 PASS Context restored event dispatched after context lost.
 PASS contextLostTest is false
 PASS ctx.isContextLost() is false
+PASS successfullyParsed is true
 
+TEST COMPLETE
+

The test doesn't set jsTestIsAsync, so the "TEST COMPLETE" is triggered by the DOMContentLoaded event.

The fix is probably to use jsTestIsAsync + finishJSTest(), or to rewrite as testharness.js.
 
Labels: Sheriff-Chromium
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3255669ed40e7dd8854253f028a23825996d198f

commit 3255669ed40e7dd8854253f028a23825996d198f
Author: Philip Jägenstedt <foolip@chromium.org>
Date: Thu Apr 06 07:54:55 2017

Mark virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html flaky

BUG= 708919 
TBR=junov@chromium.org

Review-Url: https://codereview.chromium.org/2803953002 .
Cr-Commit-Position: refs/heads/master@{#462388}

[modify] https://crrev.com/3255669ed40e7dd8854253f028a23825996d198f/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Owner: foolip@chromium.org
Status: Assigned (was: Untriaged)
Attempting fix in https://codereview.chromium.org/2799893002
Status: Fixed (was: Assigned)

Sign in to add a comment