virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html is flaky due to race between test and DOMContentLoaded |
||||
Issue descriptionThere are failures on both WebKit Mac10.11 (dbg) and WebKit Win7 (dbg): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=canvas-lose-restore-googol-size.html For both, the expected vs. actual diff looks like this: @@ -11,13 +11,13 @@ PASS ctx.isContextLost() is true PASS contextLostTest is true PASS ctx.isContextLost() is true -PASS successfullyParsed is true - -TEST COMPLETE PASS Graphics context lost event dispatched. PASS contextLostTest is true PASS ctx.isContextLost() is true PASS Context restored event dispatched after context lost. PASS contextLostTest is false PASS ctx.isContextLost() is false +PASS successfullyParsed is true +TEST COMPLETE + The test doesn't set jsTestIsAsync, so the "TEST COMPLETE" is triggered by the DOMContentLoaded event. The fix is probably to use jsTestIsAsync + finishJSTest(), or to rewrite as testharness.js.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3255669ed40e7dd8854253f028a23825996d198f commit 3255669ed40e7dd8854253f028a23825996d198f Author: Philip Jägenstedt <foolip@chromium.org> Date: Thu Apr 06 07:54:55 2017 Mark virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html flaky BUG= 708919 TBR=junov@chromium.org Review-Url: https://codereview.chromium.org/2803953002 . Cr-Commit-Position: refs/heads/master@{#462388} [modify] https://crrev.com/3255669ed40e7dd8854253f028a23825996d198f/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 6 2017
,
Apr 6 2017
Attempting fix in https://codereview.chromium.org/2799893002
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18bf204d6960d6074f8bb5be4fb93af9e92ed908 commit 18bf204d6960d6074f8bb5be4fb93af9e92ed908 Author: foolip <foolip@chromium.org> Date: Fri Apr 07 05:40:32 2017 Rewrite flaky canvas test to testharness.js to sidestep issue BUG= 708919 R=junov@chromium.org Review-Url: https://codereview.chromium.org/2799893002 Cr-Commit-Position: refs/heads/master@{#462775} [modify] https://crrev.com/18bf204d6960d6074f8bb5be4fb93af9e92ed908/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/be1feafb3ea0da9a6a3b7f48320470fb61487fc6/third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-googol-size-expected.txt [modify] https://crrev.com/18bf204d6960d6074f8bb5be4fb93af9e92ed908/third_party/WebKit/LayoutTests/fast/canvas/canvas-lose-restore-googol-size.html
,
Apr 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by foolip@chromium.org
, Apr 6 2017