"ProfilePrefStoreManagerTest/ProfilePrefStoreManagerTest.UnprotectedToProtected/1" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 12 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBQcm9maWxlUHJlZlN0b3JlTWFuYWdlclRlc3QvUHJvZmlsZVByZWZTdG9yZU1hbmFnZXJUZXN0LlVucHJvdGVjdGVkVG9Qcm90ZWN0ZWQvMQw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
Recent changes in this area: https://chromium.googlesource.com/chromium/src/+/d2e2fed00150274e4a6857c700dcb24f99793bd7 https://chromium.googlesource.com/chromium/src/+/2961ff4f598924f8132e9fc1171009cc0ee0b7d6 The first reported flake was build from commit 92d289e82e3aac87336b3ee2d50e830ae8fbf384 which is less than an hour after https://codereview.chromium.org/2745563005 so I will try reverting that.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100 commit 3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100 Author: foolip <foolip@chromium.org> Date: Thu Apr 06 06:35:29 2017 Revert of Pref service: add support for tracked prefs. (patchset #19 id:570001 of https://codereview.chromium.org/2745563005/ ) Reason for revert: ProfilePrefStoreManagerTest/ProfilePrefStoreManagerTest.UnprotectedToProtected/1 became flaky shortly after this landed. BUG= 708901 Original issue's description: > Pref service: add support for tracked prefs. > > This: > - Adds TrackedPersistentPrefStoreConfiguration: a mojo struct containing > the necessary state for constructing a PrefStore identical to the one > constructed in ProfilePrefStoreManager::CreateProfilePrefStore(). > - Moves the enums used to configure tracked prefs into the mojom. > - Extracts the creation of tracked pref store from > ProfilePrefStoreManager::CreateProfilePrefStore() into > prefs::CreateTrackedPersistentPrefStore(). > - Changes prefs::CreatePersistentPrefStore() so an appropriate > configuration results in prefs::CreateTrackedPersistentPrefStore() > being called to create the backing PrefStore. > > BUG= 654988 > > Review-Url: https://codereview.chromium.org/2745563005 > Cr-Commit-Position: refs/heads/master@{#462301} > Committed: https://chromium.googlesource.com/chromium/src/+/d2e2fed00150274e4a6857c700dcb24f99793bd7 TBR=tibell@chromium.org,bauerb@chromium.org,mbarbella@chromium.org,gab@chromium.org,mlerman@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 654988 Review-Url: https://codereview.chromium.org/2799043003 Cr-Commit-Position: refs/heads/master@{#462374} [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/prefs/chrome_pref_service_factory.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/prefs/chrome_pref_service_factory.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/prefs/profile_pref_store_manager.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/prefs/profile_pref_store_manager.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/prefs/profile_pref_store_manager_unittest.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/chrome/browser/profiles/profile_impl.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/BUILD.gn [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/persistent_pref_store_factory.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/persistent_pref_store_impl.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/persistent_pref_store_impl.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/persistent_pref_store_impl_unittest.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/public/interfaces/preferences_configuration.mojom [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/BUILD.gn [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/pref_hash_filter.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/pref_hash_filter.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/pref_hash_filter_unittest.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/segregated_pref_store.cc [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/segregated_pref_store.h [modify] https://crrev.com/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100/services/preferences/tracked/segregated_pref_store_unittest.cc [delete] https://crrev.com/6d202487ff823def4672599f51e9f13880e6b877/services/preferences/tracked/tracked_persistent_pref_store_factory.cc [delete] https://crrev.com/6d202487ff823def4672599f51e9f13880e6b877/services/preferences/tracked/tracked_persistent_pref_store_factory.h
Detected 3 new flakes for test/step "ProfilePrefStoreManagerTest/ProfilePrefStoreManagerTest.UnprotectedToProtected/1". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWwsSBUZsYWtlIlBQcm9maWxlUHJlZlN0b3JlTWFuYWdlclRlc3QvUHJvZmlsZVByZWZTdG9yZU1hbmFnZXJUZXN0LlVucHJvdGVjdGVkVG9Qcm90ZWN0ZWQvMQw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
The last flake according to #5 was *before* the revert has landed. Removing sheriffs.
Comment 1 by foolip@chromium.org
, Apr 6 2017