New issue
Advanced search Search tips

Issue 708896 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

roll_dep_svn.py fails when same deps exists in multiple deps_os entries and uses variable

Project Member Reported by kjellander@chromium.org, Apr 6 2017

Issue description

I recently ran into this issue in WebRTC, which is also easily reproducible in Chromium by rolling to an older lss revision:

$ roll-dep-svn third_party/lss 348bdf8d32b37c8fb2627df7a0a977d1d640e1fc
Pinning src/third_party/lss
to revision 348bdf8d32b37c8fb2627df7a0a977d1d640e1fc
in ./DEPS

$ git diff DEPS
diff --git a/DEPS b/DEPS
index c36d4dae62be..213269dea509 100644
--- a/DEPS
+++ b/DEPS
@@ -84,7 +84,7 @@ vars = {
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling lss
   # and whatever else without interference from each other.
-  'lss_revision': '63f24c8221a229f677d26ebe8f3d1528a9d787ac',
+  'lss_revision': '348bdf8d32b37c8fb2627df7a0a977d1d640e1fc'348bdf8d32b37c8fb2627df7a0a977d1d640e1fc7df7a0a977d1d640e1fc',
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling NaCl
   # and whatever else without interference from each other.


The resulting change is invalid and makes autorolling fail for this dependency.
The easiest workaround is to modify DEPS to avoid having the same deps multiple times. I think this only affects such deps that share a common variable for the revision.
 
I thought it might be as simple as https://chromium-review.googlesource.com/c/469606/ but I realize it's a harder problem, which I don't have time to solve.
Since https://codereview.chromium.org/2297513002/, I've considered roll-dep-svn to be owned by V8 team, as they are the only users of it. The best solution to this bug is probably to switch to using the non-svn version of deps roller.
machenbach: would you consider fixing this or have any ideas on this? It cost me quite some time.
Re 2: Seems like webrtc is a user too, which makes them an owner as well? :)

It's not broken for our auto-roller and my long-term plan is to move away from it and/or improve roll-dep with the missing features.

Sign in to add a comment