New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708894 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 658980



Sign in to add a comment

[MD Bookmarks] Support policies, including managed bookmarks

Project Member Reported by tsergeant@chromium.org, Apr 6 2017

Issue description

Full design doc on managed bookmarks and how they should work in the bookmark manager is at http://go/managed-bookmarks.

Basically, we need to make sure that we cannot delete/edit/rename/sort/move/etc any node that has |node.unmodifiable| set.

To test managed bookmarks on Linux,

```
sudo mkdir /etc/chromium
sudo chown <username> /etc/chromium
mkdir -p /etc/chromium/policies/managed/
cat <<EOF > /etc/chromium/policies/managed/test_policy.json
{
  "ManagedBookmarks" : [
    {"toplevel_name" : "Managed bookmarks"},
    {"url" : "google.com", "name" : "Google"},
    {"url" : "youtube.com", "name" : "Youtube"}, {
      "name" : "Chrome links",
      "children" : [
        {"url" : "chromium.org", "name" : "Chromium"},
        {"url" : "dev.chromium.org", "name" : "Chromium Developers"}
      ]
    }
  ]
}
EOF
```

When Chromium is restarted, a new folder of managed bookmarks will appear at the start of the bookmarks bar.
 
There's also a policy which prevents all edit operations for all bookmarks:

https://www.chromium.org/administrators/policy-list-3#EditBookmarksEnabled
Owner: tsergeant@chromium.org
Status: Started (was: Available)
Summary: [MD Bookmarks] Support policies, including managed bookmarks (was: [MD Bookmarks] Support managed bookmarks)
One more policy that we need to respect:

https://www.chromium.org/administrators/policy-list-3#IncognitoModeAvailability
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7

commit 4707d1724a8a2e4db9bc78715fe9b21fb95b10f7
Author: tsergeant <tsergeant@chromium.org>
Date: Mon Jun 05 05:47:02 2017

MD Bookmarks: Disable 'Open in Incognito Window' when Incognito is disabled

Incognito mode can be disabled by enterprise policy. This updates MD
Bookmarks to respect that policy, disabling the command to open in
incognito when incognito itself is disabled.

MD Bookmarks (unlike the old bookmark manager) will update dynamically
when the policy changes.

BUG= 708894 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2902103002
Cr-Commit-Position: refs/heads/master@{#476948}

[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/constants.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.cc
[add] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.h
[add] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_browsertest.cc
[add] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_browsertest.h
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/test/BUILD.gn
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[add] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/test/data/webui/md_bookmarks/policy_test.js
[modify] https://crrev.com/4707d1724a8a2e4db9bc78715fe9b21fb95b10f7/chrome/test/data/webui/md_bookmarks/test_store.js

Blocking: 658980
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2437f9950a67ed3838443fb8f23b7d070f69f6a8

commit 2437f9950a67ed3838443fb8f23b7d070f69f6a8
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Jun 13 23:54:47 2017

MD Bookmarks: Support policies for disabling bookmark editing

Bookmark editing can be disabled globally with the 'EditBookmarksEnabled'
policy, or for a single subtree with the 'ManagedBookmarks' policy.

This CL adds support for unmodifiable bookmarks, disabling the following
features for unmodifiable bookmarks:
* Drag and drop
* Toolbar overlay
* Toolbar overflow menu add/sort commands
* Edit/delete commands from context menus and keyboard shortcuts

BUG= 708894 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2912893002
Cr-Commit-Position: refs/heads/master@{#479211}

[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/actions.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/api_listener.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/folder_node.html
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/folder_node.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/reducers.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/toolbar.html
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/toolbar.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/types.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/resources/md_bookmarks/util.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.cc
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.h
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_browsertest.cc
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_browsertest.h
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/command_manager_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/policy_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/toolbar_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/chrome/test/data/webui/md_bookmarks/util_test.js
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.html
[modify] https://crrev.com/2437f9950a67ed3838443fb8f23b7d070f69f6a8/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_selection_overlay.js

Status: Fixed (was: Started)
Bookmarks now supports all of the policies mentioned above.

Sign in to add a comment