New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708892 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'More actions' menu list is blank on chrome://downloads.

Reported by avsha...@etouch.net, Apr 6 2017

Issue description

Chrome Version : 59.0.3064.0 (Official Build) d171113ba68ab33dc071c55d5c023d14328f453d-refs/heads/master@{#462305} 32/64 bit
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://downloads
2. Click on 'More actions' icon and observe.

Actual : 'More actions' menu list is blank on chrome://downloads.
Expected : 'More actions' list should show all available options properly.

This is a regression issue broken in ‘M-59’, below is the Manual Regression range and will soon update other info.
Good build : 59.0.3063.0
Bad build : 59.0.3064.0

Note : Will soon update other info.
 
Will soon update other OS info once the canary #59.0.3064.0 build for Mac & Linux OS is available.
Actual_Result.mp4
538 KB View Download
Expected_Result.mp4
714 KB View Download
Labels: OS-Linux OS-Mac
Update :
Above issue is also reproducible on Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) OS using latest canary #59.0.3064.0 build.

Thank you..
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3063.0 (Revision:461928).
Bad build:59.0.3064.0 (Revision:462305).

You are probably looking for a change made after 462004 (known good), but no later than 462005 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/1b260df384fd2c06a4353ca3cd9114cf77a46033..85e49faca65081cad27e7c8ed43b02261afcaa96

From the CL above, assigning the issue to the concern owner

@tsergeant: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://codereview.chromium.org/2780223004
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3064.0
Adding Release Block-Stable for this issue.Please remove if not the case.
Cc: dbeam@chromium.org
Oh, whoops. Looks like Downloads has color: white set on the text in its action-menu, and it's no longer overridden by the menu.

I can fix this tomorrow.

Comment 5 by dbeam@chromium.org, Apr 6 2017

Cc: dpa...@chromium.org
yeah, dpapad@ and I noticed this today
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00283c09b0e6479e55fd4630f49601f167fc10b0

commit 00283c09b0e6479e55fd4630f49601f167fc10b0
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Apr 07 18:23:29 2017

MD WebUI: Explicitly set text color in cr-action-menu

This fixes an issue where the menu would appear blank in MD Downloads
and Bookmarks.

BUG= 708892 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2804623005
Cr-Commit-Position: refs/heads/master@{#462930}

[modify] https://crrev.com/00283c09b0e6479e55fd4630f49601f167fc10b0/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html

Comment 7 by dbeam@chromium.org, Apr 7 2017

Status: Fixed (was: Assigned)
Labels: TE-Verified-M59 TE-Verified-59.0.3067.0 TE-Verified-59.0.3067.6
Verified the issue on Windows 7 using chrome version #59.0.3067.6 and Mac 10.12.3 and Ubuntu 14.04 using chrome version #59.0.3067.0(due to non-availability of chrome dev build #59.0.3067.6 for OS-Mac and OS-Linux) as per comment #0.

Observed that 'More actions' list shown all available options properly in chrome://Downloads. Hence, the fix is working as expected.

Attaching screen cast for reference.Hence, adding the verified labels.

Thanks...!!
708892.mp4
1.0 MB View Download

Sign in to add a comment