Impose a time limit on waiting for active worker's events before activating |
|||
Issue descriptionAfter issue 616331 , we wait for the active worker to finish its events before activating, when the waiting worker has called skipWaiting or has no clients. However we shouldn't wait forever. This is biting some sites. Proposal is to wait up to 5 minutes if skipWaiting was called or there has been no client for that duration.
,
May 9 2017
Hi - Any updates on this?
,
Jun 2 2017
Sorry for the very late response. We are pretty much doing performance work 100% for the time being.
,
Jun 2 2017
Actually, should have a patch soon.
,
Jun 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc commit 1cbcc40c91366295c1a33e80fdfd5c4811f6eebc Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Jun 30 07:13:21 2017 service worker: Cap time waiting for a busy active worker. We wait for the active worker to finish its events before activating, when the waiting worker has called skipWaiting or has no clients. However we shouldn't wait forever. This is biting some sites. This patch gives the "lame duck" active worker to 5 minutes to remain, if skipWaiting was called or there has been no client for that duration. Bug: 708880 Change-Id: I8a3c36982e734f4f6bad5fc48deeb986af00f551 Reviewed-on: https://chromium-review.googlesource.com/522187 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#483648} [modify] https://crrev.com/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc/content/browser/service_worker/service_worker_registration.cc [modify] https://crrev.com/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc/content/browser/service_worker/service_worker_registration.h [modify] https://crrev.com/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc/content/browser/service_worker/service_worker_registration_unittest.cc [modify] https://crrev.com/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc/content/browser/service_worker/service_worker_version.cc [modify] https://crrev.com/1cbcc40c91366295c1a33e80fdfd5c4811f6eebc/content/browser/service_worker/service_worker_version.h
,
Jun 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by falken@chromium.org
, Apr 6 2017