Kick start the project to move Source/web -> Source/web/core by moving WebLocalFrameImpl & it's dependencies and remove unnecessary abstractions as we go.
Overall Design Doc: http://bit.ly/2njib8d
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22b07a940d99a190bf2ccbf0c95ad66dff03526e commit 22b07a940d99a190bf2ccbf0c95ad66dff03526e Author: slangley <slangley@chromium.org> Date: Wed Apr 19 07:31:50 2017 Move FindInPagesCoordinates.* from web/ -> core/editing/. We are in the progress of removing Source/web/, and relocating files to an approprirate place in modules/ or core/. FindInPagesCoordinates has no dependencies on anything in web/ and core/editing/ seems the best future home for this class. For detailed design doc on the process of moving from web/ please refer to the doc at http://bit.ly/2njib8d. BUG= 708879 Review-Url: https://codereview.chromium.org/2828493003 Cr-Commit-Position: refs/heads/master@{#465519} [modify] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/core/editing/BUILD.gn [rename] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp [rename] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/core/editing/FindInPageCoordinates.h [modify] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/web/TextFinder.cpp [modify] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/22b07a940d99a190bf2ccbf0c95ad66dff03526e/third_party/WebKit/Source/web/tests/TextFinderTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31d2d45aa0fd1a7a8706493938c1d538abba88a9 commit 31d2d45aa0fd1a7a8706493938c1d538abba88a9 Author: slangley <slangley@chromium.org> Date: Thu Apr 20 07:42:43 2017 Move SuspendableScriptExecutor.* from web/ -> core/frame/. There is a core/frame/SuspendableTimer and the only consumer is WebLocalFrameImpl so core/frame/ seems the best place to put this. BUG= 708879 Review-Url: https://codereview.chromium.org/2832743003 Cr-Commit-Position: refs/heads/master@{#465938} [modify] https://crrev.com/31d2d45aa0fd1a7a8706493938c1d538abba88a9/third_party/WebKit/Source/core/frame/BUILD.gn [rename] https://crrev.com/31d2d45aa0fd1a7a8706493938c1d538abba88a9/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.cpp [rename] https://crrev.com/31d2d45aa0fd1a7a8706493938c1d538abba88a9/third_party/WebKit/Source/core/frame/SuspendableScriptExecutor.h [modify] https://crrev.com/31d2d45aa0fd1a7a8706493938c1d538abba88a9/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/31d2d45aa0fd1a7a8706493938c1d538abba88a9/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd61327a91c26467fae63304cc1ee343405344e6 commit fd61327a91c26467fae63304cc1ee343405344e6 Author: slangley <slangley@chromium.org> Date: Mon Apr 24 08:54:14 2017 Move WebAssociatedURLLoaderImpl.* from web/ -> core/export/. WebAssociatedURLLoaderImpl had a dependency on WebLocalFrameImpl just so it could call a method to obtain the document for the frame. To break this dependency the ctor parameter was changed to take a Document* directly. BUG= 708879 Review-Url: https://codereview.chromium.org/2831833002 Cr-Commit-Position: refs/heads/master@{#466601} [modify] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/Source/core/exported/BUILD.gn [rename] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.cpp [rename] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.h [modify] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/fd61327a91c26467fae63304cc1ee343405344e6/third_party/WebKit/public/web/WebAssociatedURLLoader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6167501ebd01a4850b5c626ccf0996e0c408723 commit a6167501ebd01a4850b5c626ccf0996e0c408723 Author: slangley <slangley@chromium.org> Date: Wed Apr 26 04:12:33 2017 Move WebDataSourceImpl from web/ -> core/exported/. WebDataSourceImpl is the implementation of public/web/WebDataSource.h so we want to move this file to core/exported. Updated all of the references to the new location. BUG= 708879 Review-Url: https://codereview.chromium.org/2832713002 Cr-Commit-Position: refs/heads/master@{#467232} [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/core/exported/BUILD.gn [rename] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/core/exported/WebDataSourceImpl.cpp [rename] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/core/exported/WebDataSourceImpl.h [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/a6167501ebd01a4850b5c626ccf0996e0c408723/third_party/WebKit/public/web/WebDataSource.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8db797d21d544547fdf4436072224c01691e938c commit 8db797d21d544547fdf4436072224c01691e938c Author: slangley <slangley@chromium.org> Date: Thu Apr 27 07:44:04 2017 Move CompositionUnderlineVectorBuilder.* from web/ -> core/editing/. Move CompositionUnderlineVectorBuilder.h to core/editing/ as part of the removal of the web/ layer. Now that core has visibility into public/web/ we can remove CompositionUnderlineBuilder entirely and just provide a copy constructor on CompositionUnderling to do the conversion from WebCompositionUnderline. BUG= 708879 Review-Url: https://codereview.chromium.org/2826373002 Cr-Commit-Position: refs/heads/master@{#467620} [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/core/editing/BUILD.gn [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/core/editing/CompositionUnderline.cpp [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/core/editing/CompositionUnderline.h [rename] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.cpp [rename] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/core/editing/CompositionUnderlineVectorBuilder.h [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/web/BUILD.gn [delete] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/third_party/WebKit/Source/web/CompositionUnderlineBuilder.h [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/8db797d21d544547fdf4436072224c01691e938c/third_party/WebKit/Source/web/WebViewImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ebe3671d78db19aa97d2c4950069c1ff837c4a5 commit 2ebe3671d78db19aa97d2c4950069c1ff837c4a5 Author: slangley <slangley@chromium.org> Date: Mon May 01 03:20:17 2017 Move SharedWorkerRepositoryClientImpl from web/ to core/exported/. SharedWorkerRepositoryClientImpl implements classes defined in public/web/ (WebSharedWorkerConnectListener, WebSharedWorkerRepositoryClient) so it is being moved to core/exported. SharedWorkerRepositoryClientImpl.cpp did include WebLocalFrameImpl but luckily enough didn't use it so we could just break this dependency. BUG= 708879 Review-Url: https://codereview.chromium.org/2833693002 Cr-Commit-Position: refs/heads/master@{#468274} [modify] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/core/exported/BUILD.gn [rename] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp [rename] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.h [modify] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/core/workers/SharedWorkerRepositoryClient.h [modify] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp [modify] https://crrev.com/2ebe3671d78db19aa97d2c4950069c1ff837c4a5/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ba3433c3a317a45c461fb499d65c7f67eecf3e7 commit 7ba3433c3a317a45c461fb499d65c7f67eecf3e7 Author: slangley <slangley@chromium.org> Date: Fri May 05 03:36:29 2017 Introduce the class webLocalFrameBase anf make WebLocalFrameImpl derived it. There are many cyclic dependencies in web/ between WebLocalFrameImpl and other classes. This makes it hard to move WebLocalFrameImpl from web/ into core/ in small, logical steps. To remove these cycles we introduce WebLocalFrameBase. Classes that depend on methods defined in WebLocalFrameImpl will be changed to depend on WebLocalFrameBase instead, by declaring these dependent methods pure virtual in WebLocalFrameBase. We can then sever the links to WebLocalFrameImpl and move classes out of Web. This CL establises the inheritence of WebLocalFrameImpl on WebLocalFrameBase, subsequent CL's will start to delcare methods in WebLocalFrameBase. BUG= 708879 Review-Url: https://codereview.chromium.org/2863853002 Cr-Commit-Position: refs/heads/master@{#469586} [modify] https://crrev.com/7ba3433c3a317a45c461fb499d65c7f67eecf3e7/third_party/WebKit/Source/core/frame/BUILD.gn [add] https://crrev.com/7ba3433c3a317a45c461fb499d65c7f67eecf3e7/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/7ba3433c3a317a45c461fb499d65c7f67eecf3e7/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/7ba3433c3a317a45c461fb499d65c7f67eecf3e7/third_party/WebKit/Source/web/WebLocalFrameImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60a6ebd54a2ab983980775cab24ac9d89cfab27d commit 60a6ebd54a2ab983980775cab24ac9d89cfab27d Author: slangley <slangley@chromium.org> Date: Mon May 08 08:09:50 2017 Provide a way to obtain WebLocalFrameBase from a LocalFrame. Provide methods that allow callers to obtain an instance of WebLocalFrameBase rather than WebLocalFrameImpl, and use this in WebDocument to remove a dependency on WebLocalFrameImpl. This moves the meat of https://codereview.chromium.org/2863913002 to this CL, as it was too difficult to concicely break the dependencies on other components in web/. I used the existing "GetWebLayerTreeView" method as the basis for calling the new method "GetWebLocalFrameBase". BUG= 708879 Review-Url: https://codereview.chromium.org/2868743002 Cr-Commit-Position: refs/heads/master@{#469920} [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/core/frame/BUILD.gn [add] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/core/frame/WebLocalFrameBase.cpp [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/core/page/ChromeClient.h [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/web/ChromeClientImpl.h [modify] https://crrev.com/60a6ebd54a2ab983980775cab24ac9d89cfab27d/third_party/WebKit/Source/web/WebDocument.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06c36803ddb5dd35d9baebce676583489cd1d7ed commit 06c36803ddb5dd35d9baebce676583489cd1d7ed Author: slangley <slangley@chromium.org> Date: Mon May 08 10:11:39 2017 Move more users of WebLocalFrameImpl to WebLocalFrameBase. This CL breaks the dependency of three more classes on WebLocalFrameImpl. To do this we introduce some pure virtual methods into WebLocalFrameBase that we override in WebLocalFrameImpl, and then update calls sites to use WebLocalFrameBase. In this case the dependencies have been broken for: - WebAXObject. - RemoteFrameClientImpl - ContextMenuClientImpl - DedicatedWorkerMessagingProxyProviderImpl BUG= 708879 Review-Url: https://codereview.chromium.org/2865953002 Cr-Commit-Position: refs/heads/master@{#469945} [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/web/WebAXObject.cpp [modify] https://crrev.com/06c36803ddb5dd35d9baebce676583489cd1d7ed/third_party/WebKit/Source/web/WebLocalFrameImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e110fbd1f3de7fc28c282d5bd034304bed5a002 commit 8e110fbd1f3de7fc28c282d5bd034304bed5a002 Author: slangley <slangley@chromium.org> Date: Mon May 08 10:12:34 2017 Removed unused LocalFrame related headers from WebNode. BUG= 708879 Review-Url: https://codereview.chromium.org/2865033002 Cr-Commit-Position: refs/heads/master@{#469946} [modify] https://crrev.com/8e110fbd1f3de7fc28c282d5bd034304bed5a002/third_party/WebKit/Source/web/WebNode.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2043010d37c8e1bebeb6599cee646d0ff206762b commit 2043010d37c8e1bebeb6599cee646d0ff206762b Author: slangley <slangley@chromium.org> Date: Tue May 09 06:48:20 2017 Remove unused include WebLocalFrameImpl from WebDOMMessageEvent. Note we can't move this file from web/ because it depends on WebFrame::ToCoreFrame that is implemented in web/. BUG= 708879 Review-Url: https://codereview.chromium.org/2872863002 Cr-Commit-Position: refs/heads/master@{#470254} [modify] https://crrev.com/2043010d37c8e1bebeb6599cee646d0ff206762b/third_party/WebKit/Source/web/WebDOMMessageEvent.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88ffa876760cfe39fc790bc1dbd901aff0e3cede commit 88ffa876760cfe39fc790bc1dbd901aff0e3cede Author: slangley <slangley@chromium.org> Date: Tue May 09 11:14:01 2017 Move more classes to use WebLocalFrameBase from WebLocalFrameImpl. These use cases do not require any further virtual methods to be declared in WebLocalFrameBase - they simply call the existing Client() method. This CL updates: - AudioOutputDeviceClientImpl.cpp - MediaKeysClientImpl.cpp - WebPluginContainerImpl.cpp BUG= 708879 Review-Url: https://codereview.chromium.org/2871833003 Cr-Commit-Position: refs/heads/master@{#470279} [modify] https://crrev.com/88ffa876760cfe39fc790bc1dbd901aff0e3cede/third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp [modify] https://crrev.com/88ffa876760cfe39fc790bc1dbd901aff0e3cede/third_party/WebKit/Source/web/MediaKeysClientImpl.cpp [modify] https://crrev.com/88ffa876760cfe39fc790bc1dbd901aff0e3cede/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c commit 5ca6168aef63ebb2106c2b4e0059d48fc9bb476c Author: slangley <slangley@chromium.org> Date: Tue May 09 12:13:59 2017 Provide downcasts for WebLocalFrameBase using DEFINE_TYPE_CASTS macro. Use new type casts to break dependency on WebLocalFrameImpl for the classes: - WebDOMFileSystem.cpp - WebFrameContentDumper.cpp - WebFrameWidgetBase.cpp. Provide new pure virtual methods GetFrame() and GetFrameView() in WebLocalFrameBase and override in WebLocalFrameImpl. BUG= 708879 Review-Url: https://codereview.chromium.org/2867073005 Cr-Commit-Position: refs/heads/master@{#470290} [modify] https://crrev.com/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c/third_party/WebKit/Source/web/WebDOMFileSystem.cpp [modify] https://crrev.com/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c/third_party/WebKit/Source/web/WebFrameContentDumper.cpp [modify] https://crrev.com/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp [modify] https://crrev.com/5ca6168aef63ebb2106c2b4e0059d48fc9bb476c/third_party/WebKit/Source/web/WebLocalFrameImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/481eb1f44f0db7dbfd321be80dccb3e0e8cbe314 commit 481eb1f44f0db7dbfd321be80dccb3e0e8cbe314 Author: slangley <slangley@chromium.org> Date: Thu May 11 10:30:07 2017 Move WebFrame to use WebLocalFrameBase instead of WebLocalFrameImpl. This requires WebLocalFrameBase become garbage collected, so moved the declaration of GarbageCollectedFinalized<> from WebLocalFrameImpl to WebLocalFrameBase, and added Tracing to WebLocalFrameBase. BUG= 708879 Review-Url: https://codereview.chromium.org/2873213003 Cr-Commit-Position: refs/heads/master@{#470903} [modify] https://crrev.com/481eb1f44f0db7dbfd321be80dccb3e0e8cbe314/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/481eb1f44f0db7dbfd321be80dccb3e0e8cbe314/third_party/WebKit/Source/web/WebFrame.cpp [modify] https://crrev.com/481eb1f44f0db7dbfd321be80dccb3e0e8cbe314/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/481eb1f44f0db7dbfd321be80dccb3e0e8cbe314/third_party/WebKit/Source/web/WebLocalFrameImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76 commit ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76 Author: slangley <slangley@chromium.org> Date: Fri May 12 15:37:47 2017 Move more classes to WebLocalFrameBase instead of WebLocalFrameImpl. This CL uses WebLocalFrameBase to break dependencies on WebLocalFrameImpl at the web/ layer. In some case, methods have been made pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl to assist with the decoupling. We need to break these dependencies so we can Move WebLocalFrameImpl to core. This CL updates: - TextFinder - WebEmbeddedWorkerImpl - WebFrameSerializer - WebFrameSerializerImpl - WebSharedWorkerImpl BUG= 708879 Review-Url: https://codereview.chromium.org/2881693002 Cr-Commit-Position: refs/heads/master@{#471308} [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/TextFinder.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/TextFinder.h [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebFrameSerializer.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebFrameSerializerImpl.h [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebScopedUserGesture.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp [modify] https://crrev.com/ee9b642ef6c3c43f8342cd3522a1367b1a9dcd76/third_party/WebKit/Source/web/WebSharedWorkerImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f325f36981d3529186e42faf140b72f064b39557 commit f325f36981d3529186e42faf140b72f064b39557 Author: slangley <slangley@chromium.org> Date: Mon May 15 07:12:00 2017 Move more classes over to use WebLocalFrameBase instead of WebLocalFrameImpl. Classes changed were: - ColorChooserUIController - ExternalPopupMenu. - IndexedDBClientImpl. - InspectorEmulationAgent. - LocalFileSystemClient. - NavigatorContentUtilsClientImpl. - PageOverlay. - RemoteFrameOwner. - StorageQuotaClientImpl. - TextCheckerClientImpl. - UserMediaClientImpl - WebHelperPluginImpl In some cases it may be possible to now move files out of web/ altogether, I will do this in follow up CLs. BUG= 708879 Review-Url: https://codereview.chromium.org/2877363002 Cr-Commit-Position: refs/heads/master@{#471687} [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/ColorChooserUIController.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/ExternalPopupMenu.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/IndexedDBClientImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/InspectorEmulationAgent.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/InspectorEmulationAgent.h [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/LocalFileSystemClient.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.h [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/PageOverlay.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/RemoteFrameOwner.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/StorageQuotaClientImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/TextCheckerClientImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/TextCheckerClientImpl.h [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/UserMediaClientImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp [modify] https://crrev.com/f325f36981d3529186e42faf140b72f064b39557/third_party/WebKit/Source/web/WebHelperPluginImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06b9f76225c4771ec0f2807dde44ae2d46ddead7 commit 06b9f76225c4771ec0f2807dde44ae2d46ddead7 Author: sashab <sashab@chromium.org> Date: Mon May 15 08:42:40 2017 Remove dependency of DateTimeChooserImpl on ChromeClientImpl Remove dependency of DateTimeChooserImpl on ChromeClientImpl, moving virtual methods into ChromeClient instead. This also required implementing the methods in EmptyChromeClient. BUG= 708879 Review-Url: https://codereview.chromium.org/2882923002 Cr-Commit-Position: refs/heads/master@{#471701} [modify] https://crrev.com/06b9f76225c4771ec0f2807dde44ae2d46ddead7/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/06b9f76225c4771ec0f2807dde44ae2d46ddead7/third_party/WebKit/Source/core/page/ChromeClient.h [modify] https://crrev.com/06b9f76225c4771ec0f2807dde44ae2d46ddead7/third_party/WebKit/Source/web/ChromeClientImpl.h [modify] https://crrev.com/06b9f76225c4771ec0f2807dde44ae2d46ddead7/third_party/WebKit/Source/web/DateTimeChooserImpl.cpp [modify] https://crrev.com/06b9f76225c4771ec0f2807dde44ae2d46ddead7/third_party/WebKit/Source/web/DateTimeChooserImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74a65b727dde1c671f3269da7605093fe7b72247 commit 74a65b727dde1c671f3269da7605093fe7b72247 Author: slangley <slangley@chromium.org> Date: Mon May 15 12:19:39 2017 Move WebInputEventConversion from web/ to core/events/. Update all include sites, and remove some unused includes from WebFrameWidgetBase.cpp. BUG= 708879 Review-Url: https://codereview.chromium.org/2876403002 Cr-Commit-Position: refs/heads/master@{#471734} [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/core/events/BUILD.gn [rename] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/core/events/WebInputEventConversion.cpp [rename] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/core/events/WebInputEventConversion.h [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/DevToolsEmulator.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/InspectorOverlayAgent.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/PageWidgetDelegate.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebPagePopupImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/74a65b727dde1c671f3269da7605093fe7b72247/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c40d5119d9f765bf455f4b42d003fd4d5e3564f commit 7c40d5119d9f765bf455f4b42d003fd4d5e3564f Author: slangley <slangley@chromium.org> Date: Tue May 16 13:23:35 2017 Move WebFrameWidgetBase to core/frame/. - Update include paths in classes that are using WebFrameViewWidgetBase. - Provide covariant overload of FrameWidget() in WebLocalFrameBase. BUG= 708879 Review-Url: https://codereview.chromium.org/2884563003 Cr-Commit-Position: refs/heads/master@{#472077} [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/core/frame/BUILD.gn [rename] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp [rename] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.h [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/web/WebFrameWidgetImpl.h [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/web/WebViewFrameWidget.h [modify] https://crrev.com/7c40d5119d9f765bf455f4b42d003fd4d5e3564f/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd3a1679f2093e60412b93e59c14bb720e306c3d commit fd3a1679f2093e60412b93e59c14bb720e306c3d Author: slangley <slangley@chromium.org> Date: Wed May 17 11:06:50 2017 Move ValidationMessageClientImpl to core/page/. In the future this can likely be refactored with ValidationMessageClient. BUG= 708879 Review-Url: https://codereview.chromium.org/2886683002 Cr-Commit-Position: refs/heads/master@{#472419} [modify] https://crrev.com/fd3a1679f2093e60412b93e59c14bb720e306c3d/third_party/WebKit/Source/core/page/BUILD.gn [rename] https://crrev.com/fd3a1679f2093e60412b93e59c14bb720e306c3d/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.cpp [rename] https://crrev.com/fd3a1679f2093e60412b93e59c14bb720e306c3d/third_party/WebKit/Source/core/page/ValidationMessageClientImpl.h [modify] https://crrev.com/fd3a1679f2093e60412b93e59c14bb720e306c3d/third_party/WebKit/Source/web/BUILD.gn [modify] https://crrev.com/fd3a1679f2093e60412b93e59c14bb720e306c3d/third_party/WebKit/Source/web/WebViewImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7c38bba708dbb4156b197acb2b44676052d0599 commit b7c38bba708dbb4156b197acb2b44676052d0599 Author: slangley <slangley@chromium.org> Date: Thu May 18 05:37:55 2017 Move LocalFrameClientImpl to use WebLocalFrameBase instead of WebLocalFrameImpl. - Update all users of GetWebFrame() to use WebLocalFrameBase. - Make methods declared only in WebLocalFrameImpl pure virtual in WebLocalFrameBase and override the methods in WebLocalFrameImpl. BUG= 708879 Review-Url: https://codereview.chromium.org/2882853006 Cr-Commit-Position: refs/heads/master@{#472685} [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/LocalFrameClientImpl.h [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.cpp [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/WebDevToolsFrontendImpl.h [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/b7c38bba708dbb4156b197acb2b44676052d0599/third_party/WebKit/Source/web/WebLocalFrameImpl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51c37035a1100e4c6e7257e4289870f7f2ac27db commit 51c37035a1100e4c6e7257e4289870f7f2ac27db Author: slangley <slangley@chromium.org> Date: Thu May 18 07:55:28 2017 Break dependency on ChromeClientImpl for WebPluginContainerImpl. Move methods that were not virtual in ChromeClientImpl to ChromeClient and make them pure virtual, override in ChromeClientImpl. BUG= 708879 Review-Url: https://codereview.chromium.org/2887633002 Cr-Commit-Position: refs/heads/master@{#472730} [modify] https://crrev.com/51c37035a1100e4c6e7257e4289870f7f2ac27db/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/51c37035a1100e4c6e7257e4289870f7f2ac27db/third_party/WebKit/Source/core/page/ChromeClient.h [modify] https://crrev.com/51c37035a1100e4c6e7257e4289870f7f2ac27db/third_party/WebKit/Source/web/ChromeClientImpl.h [modify] https://crrev.com/51c37035a1100e4c6e7257e4289870f7f2ac27db/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/171284077b44d0102ffc9065331fb3b1efe3fb67 commit 171284077b44d0102ffc9065331fb3b1efe3fb67 Author: slangley <slangley@chromium.org> Date: Wed May 24 05:45:15 2017 Move the logic to retrieve the WebPluginContainer to LocalFrame and Node. This CL moves the logic to retrieve the WebPluginContainer from static methods in WebLocalFrameImpl & WebNode to member method on LocalFrame and Node. It introduces a virtual method on PluginView to return the PluginContainer, that is overridden in WebPluginContainerBase to remove the need for down casting. Logically this CL should introduce no changes. BUG= 708879 Review-Url: https://codereview.chromium.org/2888203006 Cr-Commit-Position: refs/heads/master@{#474176} [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/core/dom/Node.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/core/frame/LocalFrame.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/core/frame/LocalFrame.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/core/plugins/PluginView.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebFrameWidgetImpl.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebInputMethodControllerImpl.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebNode.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebPluginContainerImpl.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/171284077b44d0102ffc9065331fb3b1efe3fb67/third_party/WebKit/public/web/WebNode.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7ba3ebc82c44224baf56adda18795a0578a47c9 commit f7ba3ebc82c44224baf56adda18795a0578a47c9 Author: slangley <slangley@chromium.org> Date: Wed May 24 12:39:58 2017 This CL moves many more classes over to use WebLocalFrameBase from WebLocalFrameImpl. The majority of these changes are a result of changing WebViewImpl::MainFrameImpl() to return WebLocalFrameBase*, and then fixing all of the errors that resulted. There are no logic changes with this change, only moving the code to use the abstract class rather than the concrete Impl. Some methods were only defined in WebLocalFrameImpl. In this case they were made pure virtual in WebLocalFrameBase and overriden in WebLocalFrameImpl. BUG= 708879 Review-Url: https://codereview.chromium.org/2896563002 Cr-Commit-Position: refs/heads/master@{#474262} [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/core/exported/WebViewBase.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/core/frame/WebLocalFrameBase.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/DevToolsEmulator.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/FullscreenController.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/InspectorOverlayAgent.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/InspectorOverlayAgent.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/PageOverlay.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/PageOverlay.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/WebLocalFrameImpl.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/WebViewFrameWidget.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/WebViewFrameWidget.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/WebViewImpl.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/WebViewImpl.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/FrameTestHelpers.h [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/TextFinderTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/WebFrameSerializerSanitizationTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/WebFrameTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/WebViewTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/sim/SimTest.cpp [modify] https://crrev.com/f7ba3ebc82c44224baf56adda18795a0578a47c9/third_party/WebKit/Source/web/tests/sim/SimTest.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2 commit cd4e07b5898a1a7f287085aa900f0ffbb77acbe2 Author: slangley <slangley@chromium.org> Date: Mon May 29 03:01:17 2017 Move many more classes to use WebLocalFrameBase over WebLocalFrameImpl. In the majority of these case, we just adjust the header to include core/frame/WebLocalFrameBase.h instead of wevb/WebLocalFrameImpl.h, as the class is just needs to update the definition. In some cases we also needed to change the downcaststs to WebLocalFrameBase. BUG= 708879 Review-Url: https://codereview.chromium.org/2900593002 Cr-Commit-Position: refs/heads/master@{#475280} [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/LinkHighlightImpl.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/LinkHighlightImplTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/PageOverlayTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebFrameWidgetImpl.h [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebSurroundingText.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/WebUserGestureIndicator.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/AnimationSimTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/DeferredLoadingTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/PrerenderingTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ScrollMetricsTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/scheduler/ActiveConnectionThrottlingTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/scheduler/FrameThrottlingTest.cpp [modify] https://crrev.com/cd4e07b5898a1a7f287085aa900f0ffbb77acbe2/third_party/WebKit/Source/web/tests/sim/SimCompositor.cpp
Comment 1 by slangley@chromium.org
, Apr 6 2017