MD Settings: Profile avatar scaled up and cropped |
||||||
Issue descriptionThe profile icon in the People section top row is pixelated (scaled up) and cropped into a circle. Compare the attached avatar.png with the icon showed in the user manager (pod.png). Elsewhere in Chrome, the avatar isn't shown inside a circular mask, and the icons don't seem particularly designed to be circular (see how the top-left of the martini glass is chopped off in the attachment, and the shadows are cut off too). I demand crisp, non-chipped martini glasses in Settings!
,
Apr 6 2017
From bug 703834 (that I'm duping to this bug - almost duped the other way, but this one has pictures!). open chrome://settings and look at the avatar icon in the People section. It's a touch blurry. It looks like we are fetching a 38px by 31px and scaling it to 40x40px. Something to consider(?): The 38x31px icon is the x1 scale icon. The x2 scale icon is 76px by 32px and looks a bit sharper when scaled down. (i.e. an image is sharper if a large image is scaled down; rather than a smaller image scaled up).
,
Apr 6 2017
Issue 703834 has been merged into this issue.
,
Apr 6 2017
#1: tested with beta and canary. dschuyler: sorry for the dupe! I always have "Component:UI>Settings" in my searches.
,
Apr 11 2017
We should really fix this before launch. It's literally the first thing your eye looks at when opening chrome://settings.
,
Apr 11 2017
,
Apr 11 2017
,
Apr 11 2017
Looks great!
,
Apr 11 2017
dschuyler@ and I have been pair programming this with tommycli@'s help. we're trading this P1 issue for a P3 issue of the blue outline not working correctly when changing your profile picture. this seems like way less of a deal (clicking the icon works, going back work, but initially showing the blue line around profile pictures when editing your profile is likely to fail).
,
Apr 11 2017
here's more details on the P3 we're trading for: issue 710660
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42652efd4bbbaffa83de98b4bcf57e270d0e8ccb commit 42652efd4bbbaffa83de98b4bcf57e270d0e8ccb Author: dbeam <dbeam@chromium.org> Date: Wed Apr 12 00:47:59 2017 MD Settings: get the avatar icon the same way the user switcher does R=dschuyler@chromium.org BUG= 708863 Review-Url: https://codereview.chromium.org/2807373003 Cr-Commit-Position: refs/heads/master@{#463861} [modify] https://crrev.com/42652efd4bbbaffa83de98b4bcf57e270d0e8ccb/chrome/browser/ui/webui/settings/profile_info_handler.cc [modify] https://crrev.com/42652efd4bbbaffa83de98b4bcf57e270d0e8ccb/chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc
,
Apr 12 2017
,
Apr 12 2017
Huge improvement, thanks Dan, Dave and Tommy!
,
May 1 2017
Issue 716269 has been merged into this issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dbeam@chromium.org
, Apr 6 2017Labels: Hotlist-MD-Settings-People