Issue metadata
Sign in to add a comment
|
"AutofillInteractiveTest.AutofillAfterReload" is flaky |
||||||||||||||||||||||||
Issue description"AutofillInteractiveTest.AutofillAfterReload" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 21 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5BdXRvZmlsbEFmdGVyUmVsb2FkDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53436789712c58d9f7d512e6615b4acf46e52f28 commit 53436789712c58d9f7d512e6615b4acf46e52f28 Author: foolip <foolip@chromium.org> Date: Thu Apr 06 04:28:14 2017 Revert of cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe (patchset #1 id:1 of https://codereview.chromium.org/2794153002/ ) Reason for revert: AutofillInteractiveTest.AutofillAfterReload became flaky right after this landed. The test involves focus (FocusFirstNameField()) and the change also involves focus, so there is likely a connection. BUG= 708861 Original issue's description: > cros: Fix keyboard navigation focus get lost when system tray set to invisible on oobe > > Changes: > (1) add tray->visible() check in WebUILoginView::TakeFocus(). > (2) add else branch to avoid an invisible focus stop. > > BUG= 707977 > TEST=test that focus loop works > > Review-Url: https://codereview.chromium.org/2794153002 > Cr-Commit-Position: refs/heads/master@{#461741} > Committed: https://chromium.googlesource.com/chromium/src/+/43c00b6dfca02767efa66d7fb110c7cbf28bc019 TBR=xiyuan@chromium.org,warx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 707977 Review-Url: https://codereview.chromium.org/2801853003 Cr-Commit-Position: refs/heads/master@{#462355} [modify] https://crrev.com/53436789712c58d9f7d512e6615b4acf46e52f28/chrome/browser/chromeos/login/ui/webui_login_view.cc
,
Apr 6 2017
No flake in the >1h since the revert, assuming that fixed it.
,
Apr 6 2017
hmm, I don't think it is related to my CL, as I run the test WebUILoginView::TakeFocus is not called.
,
Apr 6 2017
After checking https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5BdXRvZmlsbEFmdGVyUmVsb2FkDA, test failure still happens today. I am going to reland my CL.
,
Apr 7 2017
Detected 20 new flakes for test/step "AutofillInteractiveTest.AutofillAfterReload". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNgsSBUZsYWtlIitBdXRvZmlsbEludGVyYWN0aXZlVGVzdC5BdXRvZmlsbEFmdGVyUmVsb2FkDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Apr 7 2017
sebsg@ - can you PTAL? This looks possibly similar to issue 646576 . BTW: I see that you've marked issue 646576 in Sep 2016, but the AutofillInteractiveTest.AutofillEvents test is still disabled on ChromeOS - is there another bug that tracks the work to investigate the flakiness and reenable the test? In the meantime - I'll put together a CL to disable AutofillInteractiveTest.AutofillAfterReload on ChromeOS.
,
Apr 7 2017
I created https://bugs.chromium.org/p/chromium/issues/detail?id=709531 to track the investigation to fix the flakiness.
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7bcfaf35f821b8d95dcd0b5e9b70be1116bc56a commit e7bcfaf35f821b8d95dcd0b5e9b70be1116bc56a Author: lukasza <lukasza@chromium.org> Date: Fri Apr 07 18:09:59 2017 Disable flaky AutofillInteractiveTest.AutofillAfterReload on ChromeOS. BUG= 708861 TBR=sebsg@chromium.org Review-Url: https://codereview.chromium.org/2806693003 Cr-Commit-Position: refs/heads/master@{#462922} [modify] https://crrev.com/e7bcfaf35f821b8d95dcd0b5e9b70be1116bc56a/chrome/browser/autofill/autofill_interactive_uitest.cc
,
Apr 7 2017
This hopefully shouldn't need sheriff attention after #c9
,
Apr 19 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by foolip@chromium.org
, Apr 6 2017Status: Assigned (was: Untriaged)