New issue
Advanced search Search tips

Issue 708851 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

realtek-rt2800-firmware: replace with linux-firmware

Project Member Reported by vapier@chromium.org, Apr 6 2017

Issue description

realtek-rt2800-firmware exists to install the rt2870.bin firmware, but the common linux-firmware package provides that for us now too.  let's drop our custom local file in favor of the linux-firmware version.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/31899a5d032710f37cca3c7ddbf7852c7d67d16f

commit 31899a5d032710f37cca3c7ddbf7852c7d67d16f
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Apr 08 04:54:20 2017

linux-firmware: only set blockers in RDEPEND

There's no need to block files at build time, just runtime, so simplify
the depstring a bit.

BUG= chromium:708851 
TEST=precq still works

Change-Id: I9dc500749749389bdb0aa34c2c09ba8cdcafa62f
Reviewed-on: https://chromium-review.googlesource.com/469387
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/31899a5d032710f37cca3c7ddbf7852c7d67d16f/sys-kernel/linux-firmware/linux-firmware-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/deb2c1c8ae3a5f8b7b551941b7b069a0cebdf25a

commit deb2c1c8ae3a5f8b7b551941b7b069a0cebdf25a
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Apr 12 06:26:08 2017

linux-firmware: support installing RT2800 firmware from here

Since linux-firmware can install this firmware, we don't need the
dedicated realtek-rt2800-firmware package.  Add the USE flags to
support this mode (although we don't turn it on just yet).

BUG= chromium:708851 
TEST=precq still passes

Change-Id: Ifce62accbc39397125e40c0e51474cd734f27dcd
Reviewed-on: https://chromium-review.googlesource.com/469388
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/deb2c1c8ae3a5f8b7b551941b7b069a0cebdf25a/virtual/target-chromium-os/target-chromium-os-1-r67.ebuild
[modify] https://crrev.com/deb2c1c8ae3a5f8b7b551941b7b069a0cebdf25a/sys-kernel/linux-firmware/linux-firmware-9999.ebuild
[modify] https://crrev.com/deb2c1c8ae3a5f8b7b551941b7b069a0cebdf25a/virtual/target-chromium-os/target-chromium-os-1.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/50e95f46f6e3579aa485a3f671554b9981c328c0

commit 50e95f46f6e3579aa485a3f671554b9981c328c0
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Apr 13 05:42:01 2017

enable rt2800 firmware in standard Chrome OS devices

We're already pulling this in via realtek-rt2800-firmware, so this
flag is switching us over to linux-firmware.

BUG= chromium:708851 
TEST=precq still passes

Change-Id: I600ce5dcfb5921a7ee1b9939c050881fb582a0e1
Reviewed-on: https://chromium-review.googlesource.com/469389
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/50e95f46f6e3579aa485a3f671554b9981c328c0/profiles/targets/chromeos/make.defaults
[modify] https://crrev.com/50e95f46f6e3579aa485a3f671554b9981c328c0/profiles/features/embedded/make.defaults

Comment 5 by vapier@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 9 by vapier@chromium.org, Jun 21 2018

Status: Fixed (was: Archived)
Status: Verified (was: Fixed)
Bulk verify old fixed bugs...

Sign in to add a comment