New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708844 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 710943
issue 710945
issue 710947
issue 710952
issue 711521
issue 711542
issue 711864
issue 712061
issue 712806
issue 714222
issue 714223
issue 717327
issue 717395
issue 718470

Blocking:
issue 712826



Sign in to add a comment

Implement a search widget for the launcher home screen

Project Member Reported by dfalcant...@chromium.org, Apr 6 2017

Issue description

Voice queries seem to be broken on my KK device.  Investigating.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e63e28f00da6f1670b2a72d8511f70259b294e4c

commit e63e28f00da6f1670b2a72d8511f70259b294e4c
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Apr 07 18:25:08 2017

πŸ” Clean up the search widget code

* It's technically infeasible to assume that the search box
  can animate to the correct location all the time.  Instead,
  just remove all of this code and keep it simple.

* Since we're allowed to add resources now, move most
  initialization of the SearchActivity layout to XML.

* Make the SearchActivity's LocationBarLayout inherit from
  the LocationBarPhone, instead.  That's how it behaves
  anyway.

* Makes the Omnibox full bleed like UX requested.

BUG= 708844 
SCREENSHOTS=https://drive.google.com/corp/drive/folders/0B7c8ZkXVwskDdGF1NVo3ZWptTzQ

Review-Url: https://codereview.chromium.org/2799783003
Cr-Commit-Position: refs/heads/master@{#462931}

[add] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java/res/layout/search_activity.xml
[delete] https://crrev.com/00283c09b0e6479e55fd4630f49601f167fc10b0/chrome/android/java/res/layout/search_widget_template_transparent.xml
[delete] https://crrev.com/00283c09b0e6479e55fd4630f49601f167fc10b0/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/BoxAnimatorScrim.java
[modify] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[add] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityFadingBackgroundView.java
[rename] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/e63e28f00da6f1670b2a72d8511f70259b294e4c/chrome/android/java_sources.gni

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f5e90160be0556460c03c7cdfb91dd10016af28

commit 8f5e90160be0556460c03c7cdfb91dd10016af28
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Apr 07 23:19:30 2017

πŸ” Switch to using the generic LocationBarLayout

Tablet devices don't like using the LocationBarPhone.  Switch
to using the LocationBarLayout as a generic class again.

BUG= 708844 

Review-Url: https://codereview.chromium.org/2799343005
Cr-Commit-Position: refs/heads/master@{#463042}

[modify] https://crrev.com/8f5e90160be0556460c03c7cdfb91dd10016af28/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1204d2395bf8818c777c3af005f046b9d11036b9

commit 1204d2395bf8818c777c3af005f046b9d11036b9
Author: dfalcantara <dfalcantara@chromium.org>
Date: Sat Apr 08 01:00:32 2017

πŸ” Hide the Google G by default

Inflate the logo inside of the LocationBarPhone instead
of having it always be inflated for LocationBar subclasses.
This is more efficient and slightly harder to break than
the solution we'd discussed offline, where the FrameLayout
was just set to View.GONE initially.

I might have to follow up eventuallyβ„’ with a CL to make the
visibility checks more robust later on.

BUG= 708844 

Review-Url: https://codereview.chromium.org/2806753003
Cr-Commit-Position: refs/heads/master@{#463087}

[modify] https://crrev.com/1204d2395bf8818c777c3af005f046b9d11036b9/chrome/android/java/res/layout/location_bar.xml
[add] https://crrev.com/1204d2395bf8818c777c3af005f046b9d11036b9/chrome/android/java/res/layout/location_bar_google_g.xml
[modify] https://crrev.com/1204d2395bf8818c777c3af005f046b9d11036b9/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/1204d2395bf8818c777c3af005f046b9d11036b9/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24f29cd501c22986c8b80fbf4283c734be81c2b9

commit 24f29cd501c22986c8b80fbf4283c734be81c2b9
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Apr 11 19:15:37 2017

πŸ” Continue working on the search widget prototype

General cleanup:
* Further encapsulate the SearchActivityLocationBarLayout.

* Enable the search widget on Canary so that we can get
  _some_ testing.

Microphone fixes:
* Switch to singleTask so that the microphone works on JB
  and KK: Android changed semantics for
  startActivityForResult for singleInstance tasks somewhere
  after that.  We were already properly handling singleTask
  behavior because of the onNewIntent call anyway.

* Hook into Activity#onRequestPermissionsResult so that
  we can properly listen for permissions changes and trigger
  a voice query afterward.

* If we're not confident in the search query, the result is
  put into the text box.  Hitting enter previously sent you
  to the first link in the suggestions instead of properly
  regenerating them.  This was fixed by avoiding trying to
  refocus and reset the query when the microphone result
  came in.

Transition fixes:
* Stop calling finish() from onStop().  This messed up when
  the user went to recents and then re-entered the
  SearchActivity immediately.

* Clean up some more of the activity creation, including
  getting rid of an unnecessary style.  This fixes up
  some of the background color transitions slightly.

BUG= 708844 

Review-Url: https://codereview.chromium.org/2814593003
Cr-Commit-Position: refs/heads/master@{#463715}

[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/res/layout/search_activity.xml
[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/24f29cd501c22986c8b80fbf4283c734be81c2b9/chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java

Blockedon: 710943
Blockedon: 710945
Blockedon: 710947
Blockedon: 710952
Components: UI>Browser>Mobile
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7a69bb4cd303a42dc88d7c432db85f570b9d33d

commit b7a69bb4cd303a42dc88d7c432db85f570b9d33d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Wed Apr 12 19:05:12 2017

πŸ” Move WindowAndroid knowledge up to the base class

With half of the direct AsyncInitializationActivity subclasses now
needing knowledge of the WindowAndroid and how to pass things to it
when the Activity requests permission, it makes sense to pull this
up.  Subclasses are still required to instantiate the WindowAndroid
on their own, but the base class will now try to direct things to it
when needed.

Also fixes what seems like a bug where setContentView is called but
onSetContentView isn't.  I don't think the LaunchBehindWorkaround
is needed anymore given that document mode is dead, but I'm not
comfortable with removing it.

BUG= 708844 

Review-Url: https://codereview.chromium.org/2811093004
Cr-Commit-Position: refs/heads/master@{#464099}

[modify] https://crrev.com/b7a69bb4cd303a42dc88d7c432db85f570b9d33d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/b7a69bb4cd303a42dc88d7c432db85f570b9d33d/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/b7a69bb4cd303a42dc88d7c432db85f570b9d33d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java

Blockedon: 711362
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ef9faffba78738c37df77a160fea80ee5f604af

commit 8ef9faffba78738c37df77a160fea80ee5f604af
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Apr 13 23:30:05 2017

πŸ” Update how shared preferences are handled by the widget

* Return the widget to the regular browser process.  SharedPreferences
  don't interact well with multiple processes because they're cached
  per process.

* Add the ability to cache whether or not a voice query is possible,
  then use that to determine whether a microphone should be visible.

* Remove caching of the search engine name as a static String.  The
  user will generally have only one widget.  I doubt it helped much,
  and it complicated the code a bit.

* Add support for resetting the widget when Clank's data is cleared.

* Instead of updating all the widgets via another broadcast, just do
  it synchronously when it's called.

Minor things:
* Set a background color explicitly so that it doesn't come up white.

* Remove Herb-related launching.

BUG= 708844 ,710943,710947

Review-Url: https://codereview.chromium.org/2816733003
Cr-Commit-Position: refs/heads/master@{#464605}

[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/res/layout/search_activity.xml
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/res/values-v17/styles.xml
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/8ef9faffba78738c37df77a160fea80ee5f604af/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java

Blockedon: 711521
Blockedon: 711542
Project Member

Comment 16 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28

commit 71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri Apr 14 21:18:23 2017

πŸ” Refactor LocationBarLayout to fix SearchActivity's location bar

* Pull out generic location_bar.xml bits into location_bar_base.xml,
  then make the original location_bar.xml file include it.  This allows
  the standard LocationBarLayout classes to work as they have before.

* Refactor the LocationBarLayout so that it moves some common button
  updating functionality upwards.

* Use a standard layout between phones and tablets.

* Fix the SearchActivityLocationBarLayout so that it shows the microphone
  and delete all buttons.

* More carefully align the location bar icons with the suggestion bar
  icons in both layouts.

Screenshots/videos:
https://drive.google.com/corp/drive/u/0/folders/0B7c8ZkXVwskDZXY3c0NPZFJvVW8

BUG= 708844 ,710945,711542

Review-Url: https://codereview.chromium.org/2819743003
Cr-Commit-Position: refs/heads/master@{#464797}

[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/res/layout/location_bar.xml
[add] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/res/layout/location_bar_base.xml
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/res/layout/search_activity.xml
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/res/values-sw600dp/dimens.xml
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
[modify] https://crrev.com/71aff04f37fb3dc76de1fe1dc0bdc66dde4e2b28/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java

Blockedon: 712061
Blockedon: 711864
Blockedon: 712263
Labels: -Restrict-View-Google
Cc: k...@chromium.org
Summary: Implement a search widget for the launcher home screen (was: [RVG] Implement a search widget for the launcher home screen)
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/493c47dd802534fa89c50c48fc9c6f72622b067d

commit 493c47dd802534fa89c50c48fc9c6f72622b067d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Apr 18 19:37:14 2017

πŸ” Add basic search widget test

* Adds a basic test that confirms that what is displayed by the
  widget accurately reflects SharedPreference state.

* Adds a pair of tests that confirm that clicking on the widget
  either starts a text or voice query.

* Adds a Delegate to the SearchWidgetProvider to control what it
  interacts with and how.

* Fixes the IntentFilters for the SearchWidgetProvider.  Not sure
  they're actually necessary, given that we directly send the
  Intent to the class (it was working while this was wrong).

BUG= 708844 

Review-Url: https://codereview.chromium.org/2819083002
Cr-Commit-Position: refs/heads/master@{#465328}

[modify] https://crrev.com/493c47dd802534fa89c50c48fc9c6f72622b067d/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/493c47dd802534fa89c50c48fc9c6f72622b067d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/493c47dd802534fa89c50c48fc9c6f72622b067d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/493c47dd802534fa89c50c48fc9c6f72622b067d/chrome/android/java_sources.gni
[add] https://crrev.com/493c47dd802534fa89c50c48fc9c6f72622b067d/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java

Blockedon: 712806

Comment 24 by k...@chromium.org, Apr 18 2017

Blockedon: 712826
Blockedon: -712826
Blocking: 712826
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32cf78bd306f2750fbc5deb14e33169c894be70

commit f32cf78bd306f2750fbc5deb14e33169c894be70
Author: dfalcantara <dfalcantara@chromium.org>
Date: Thu Apr 20 21:01:50 2017

πŸ” General widget fixes

* Clean up initialization slightly.  Now that there's no animation to show,
  we can reduce the deviation from the main pathway.

* Add a "temporary" title to the search widget so it doesn't just say
  "Chromium" when adding the widget.

* Swallow exceptions when the BroadcastReceiver is triggered via an Intent
  and tries to do anything.  This prevents us from getting into situations
  where Android believes the "process is bad" and refuses to let the widget
  work, but it does mask when real crashes happen.  After three crashes we
  just let it crash as intended so that the dump uploads.

BUG= 708844 ,712061

Review-Url: https://codereview.chromium.org/2822633002
Cr-Commit-Position: refs/heads/master@{#466127}

[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/res_chromium/values/channel_constants.xml
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchBoxDataProvider.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/f32cf78bd306f2750fbc5deb14e33169c894be70/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java

Blockedon: 714222
Blockedon: 714223
Project Member

Comment 30 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418

commit 40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418
Author: dfalcantara <dfalcantara@chromium.org>
Date: Mon Apr 24 20:38:21 2017

πŸ” More consistent first run triggering

If the user tries to launch an AsyncInitializationActivity (tabbed mode or not),
but has not yet gone through first run, force them to do so by launching it in
the same way the ChromeLauncherActivity does it.  By reusing the codepath, we
reduce the number of ways we can mess up this flow.

* Pull ChromeLauncherActivity#launchFirstRunExperience out into a static
  function in FirstRunFlowSequencer.

* Simplify the logic to not care about whether it's in tabbed mode or not.

* Call that function directly from ChromeLauncherActivity for all modes (tabbed
  or otherwise)

* Also call it from AsyncInitializationActivity in the failure case.  This
  requires fixing ChromeActivity#destroy() so that it doesn't try to undo
  anything that didn't happen because the Activity was killed early.

* Makes the SearchWidgetProvider check if First Run is required before allowing
  the user into the SearchActivity.

* Fixes how PendingIntent flags are created for FirstRun.  It was, for some
  reason, using the Intent's flags instead of using PendingIntent flags.

* Take out the "First Run Experience" app label.  Going to Recents and seeing it
  is strange.  It just uses the app name, now.

* Replaces a bunch of the old tests with new ones that account for redirecting.

* Fixes SyncTestBase so that it clears data before creating a SharedPref.  This
  caches the SharedPrefs and makes the data clear completely useless, causing
  different test runs to affect each other.

BUG= 708844 ,710952,616456

Review-Url: https://codereview.chromium.org/2833673003
Cr-Commit-Position: refs/heads/master@{#466748}

[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java
[modify] https://crrev.com/40127a47c9fb31fbc46aff7a7ad6f5bd8ea09418/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java

Project Member

Comment 31 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17a2b98bcd2527244aadd8b73d6c6125ce083011

commit 17a2b98bcd2527244aadd8b73d6c6125ce083011
Author: dfalcantara <dfalcantara@chromium.org>
Date: Mon Apr 24 20:48:57 2017

πŸ” Make the widget taller and usable on all channels

* Increase the height of the widget to 48dp.

* Remove the channel restriction on the widget.

BUG= 708844 

Review-Url: https://codereview.chromium.org/2837503003
Cr-Commit-Position: refs/heads/master@{#466754}

[modify] https://crrev.com/17a2b98bcd2527244aadd8b73d6c6125ce083011/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/17a2b98bcd2527244aadd8b73d6c6125ce083011/chrome/android/java/res/layout/search_widget_template.xml

Project Member

Comment 32 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffdac2746296923b2658e9b7fa4a4e6f4ee79184

commit ffdac2746296923b2658e9b7fa4a4e6f4ee79184
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Apr 25 00:35:59 2017

πŸ” Don't display the search engine until First Run completes

* Adds a check to prevent showing branding if First Run hasn't completed.

* Updates the widget so that it is updated when an AsyncInitializationActivity
  subclass calls onDeferredStartup().

* Changes the resource for the microphone to match the omnibox's, as well as
  uses its content description.

* Adds tests to confirm that the search engine is updated once First Run
  completes.

BUG= 708844 ,710952

Review-Url: https://codereview.chromium.org/2834253002
Cr-Commit-Position: refs/heads/master@{#466839}

[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/java/res/layout/search_widget_template.xml
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/java_sources.gni
[add] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunActivityTestObserver.java
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java
[modify] https://crrev.com/ffdac2746296923b2658e9b7fa4a4e6f4ee79184/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387c2f19a653715fc14e8ee857fba3323fa92ba8

commit 387c2f19a653715fc14e8ee857fba3323fa92ba8
Author: perezju <perezju@chromium.org>
Date: Tue Apr 25 11:55:48 2017

Revert of πŸ” Don't display the search engine until First Run completes (patchset #9 id:160001 of https://codereview.chromium.org/2834253002/ )

Reason for revert:
Appears to have broken FirstRunIntegrationTest#testClickThroughFirstRun
 crbug.com/715054 

Original issue's description:
> πŸ” Don't display the search engine until First Run completes
>
> * Adds a check to prevent showing branding if First Run hasn't completed.
>
> * Updates the widget so that it is updated when an AsyncInitializationActivity
>   subclass calls onDeferredStartup().
>
> * Changes the resource for the microphone to match the omnibox's, as well as
>   uses its content description.
>
> * Adds tests to confirm that the search engine is updated once First Run
>   completes.
>
> BUG= 708844 ,710952
>
> Review-Url: https://codereview.chromium.org/2834253002
> Cr-Commit-Position: refs/heads/master@{#466839}
> Committed: https://chromium.googlesource.com/chromium/src/+/ffdac2746296923b2658e9b7fa4a4e6f4ee79184

TBR=tedchoc@chromium.org,yusufo@chromium.org,dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 708844 ,710952

Review-Url: https://codereview.chromium.org/2839943002
Cr-Commit-Position: refs/heads/master@{#466946}

[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/java/res/layout/search_widget_template.xml
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/java_sources.gni
[delete] https://crrev.com/e24ac173c01a5de77f321f7a9789dd6adbaf4b34/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunActivityTestObserver.java
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java
[modify] https://crrev.com/387c2f19a653715fc14e8ee857fba3323fa92ba8/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java

Cc: dfalcant...@chromium.org
 Issue 715054  has been merged into this issue.
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9dd458eef1094639d4216edcf95a01d1f248f1d

commit c9dd458eef1094639d4216edcf95a01d1f248f1d
Author: dfalcantara <dfalcantara@chromium.org>
Date: Tue Apr 25 21:41:10 2017

πŸ” Reland: Don't display the search engine until First Run completes

* Adds a check to prevent showing branding if First Run hasn't completed.

* Updates the widget so that it is updated when an AsyncInitializationActivity
  subclass calls onDeferredStartup().

* Changes the resource for the microphone to match the omnibox's, as well as
  uses its content description.

* Adds tests to confirm that the search engine is updated once First Run
  completes.

BUG= 708844 ,710952, 715054 

Original-Review-Url: https://codereview.chromium.org/2834253002
Original-Cr-Commit-Position: refs/heads/master@{#466839}
Review-Url: https://codereview.chromium.org/2837343002
Cr-Commit-Position: refs/heads/master@{#467122}

[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/res/layout/search_widget_template.xml
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/java_sources.gni
[add] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunActivityTestObserver.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java
[modify] https://crrev.com/c9dd458eef1094639d4216edcf95a01d1f248f1d/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java

Blockedon: 715020
Components: -UI>Browser>Mobile UI>Browser>Mobile>SearchWidget
Blockedon: 717327
Blockedon: 717395
Blockedon: 718470
Project Member

Comment 42 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be19b0286e7a728f3f4f2bea96552959b900e923

commit be19b0286e7a728f3f4f2bea96552959b900e923
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri May 05 06:23:39 2017

πŸ” More SearchActivity tests

Fixes:
* Previously, typing in something before native finished loading
  didn't let autocomplete suggestions appear.

* Set OWNERS files with noparent so we're forced to review changes
  that could affect the search engine dialogs.

Tests:
* Adds a set of tests that monitors delays loading native and acts
  on the SearchActivity.

BUG= 708844 , 712833, 712836, 717327

Review-Url: https://codereview.chromium.org/2860313002
Cr-Commit-Position: refs/heads/master@{#469605}

[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/res/layout/default_search_engine_first_run_fragment.xml
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/res/values/ids.xml
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/firstrun/DefaultSearchEngineFirstRunFragment.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEnginePromoDialog.java
[add] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/locale/OWNERS
[add] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/OWNERS
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProvider.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/java_sources.gni
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
[add] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperUtils.java
[add] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/locale/OWNERS
[add] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/OWNERS
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchActivityTest.java
[modify] https://crrev.com/be19b0286e7a728f3f4f2bea96552959b900e923/chrome/android/javatests/src/org/chromium/chrome/browser/searchwidget/SearchWidgetProviderTest.java

Project Member

Comment 43 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d365785b6ba6382d696412fef975bb2e05c23b

commit 47d365785b6ba6382d696412fef975bb2e05c23b
Author: dfalcantara <dfalcantara@chromium.org>
Date: Fri May 05 23:56:42 2017

πŸ” Update widget provider info

Adds a preview image and marks categories for where the
widget can be installed.

BUG= 718470 , 708844 

Review-Url: https://codereview.chromium.org/2864023002
Cr-Commit-Position: refs/heads/master@{#469816}

[add] https://crrev.com/47d365785b6ba6382d696412fef975bb2e05c23b/chrome/android/java/res/drawable-nodpi/widget_preview.png
[modify] https://crrev.com/47d365785b6ba6382d696412fef975bb2e05c23b/chrome/android/java/res/xml/search_widget_info.xml

Cc: -tedc...@chromium.org -dfalcant...@chromium.org
Owner: tedc...@chromium.org
Blockedon: -715020
Blockedon: -712263
Blockedon: -711362
Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
No merge request needed, this was the master tracking bug.

Sign in to add a comment