New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708835 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

CFI Linux ToT is failing angle_unittests (signal 4 in ValidationESTest.DrawElementsWithMaxIndexGivesError)

Project Member Reported by inglorion@chromium.org, Apr 6 2017

Issue description

First failing build: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/5937

Failure:
[ RUN      ] ValidationESTest.DrawElementsWithMaxIndexGivesError
Received signal 4 ILL_ILLOPN 0000006c49ae
CFI: Most likely a control flow integrity violation; for more information see:
https://www.chromium.org/developers/testing/control-flow-integrity
#0 0x00000065f24c base::debug::StackTrace::StackTrace()
#1 0x00000065e873 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f6e18d3d330 <unknown>
#3 0x0000006c49ae gl::Framebuffer::checkStatus()
#4 0x0000006d6f44 gl::ValidateDrawBase()
#5 0x0000006d7752 gl::ValidateDrawElements()
#6 0x000000540f76 (anonymous namespace)::ValidationESTest_DrawElementsWithMaxIndexGivesError_Test::TestBody()
#7 0x0000006ad132 testing::Test::Run()
#8 0x0000006ae670 testing::TestInfo::Run()
#9 0x0000006ae917 testing::TestCase::Run()
#10 0x0000006b3487 testing::internal::UnitTestImpl::RunAllTests()
#11 0x0000006b30d4 testing::UnitTest::Run()
#12 0x000000688e19 base::TestSuite::Run()
#13 0x000000636475 (anonymous namespace)::RunHelper()
#14 0x000000689f0d base::(anonymous namespace)::LaunchUnitTestsInternal()
#15 0x00000068cf47 base::LaunchUnitTestsSerially()
#16 0x0000006363a8 main
#17 0x7f6e17e6cf45 __libc_start_main
#18 0x00000046383c <unknown>
  r8: 0000000000000000  r9: 0000000000000001 r10: 00007f6e1881b940 r11: 00007f6e17fd4cf0
 r12: 00000490052be600 r13: 00007ffef4c19e28 r14: 0000000000000003 r15: 00007ffef4c1a058
  di: 00000490052be600  si: 00007ffef4c19e28  bp: 00007ffef4c198e0  bx: 00000490052be600
  dx: 0000049005499600  ax: 00007ffef4c19b40  cx: 0000000000000070  sp: 00007ffef4c198d0
  ip: 00000000006c49ae efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000006 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[5597/5597] ValidationESTest.DrawElementsWithMaxIndexGivesError (CRASHED)
 
Cc: jmad...@chromium.org
jmadill, any chance this may have been triggered by the ANGLE roll in https://codereview.chromium.org/2796413002 ?
Cc: krasin@chromium.org inglorion@chromium.org
Owner: jmad...@chromium.org
Status: Assigned (was: Available)
Yes, Ivan pointed this out last night.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/fa416b18e3903d2f0bb6d7a9b6ac34e3e658b1bc

commit fa416b18e3903d2f0bb6d7a9b6ac34e3e658b1bc
Author: Jamie Madill <jmadill@chromium.org>
Date: Thu Apr 06 16:14:26 2017

Disable ValidationESTest.DrawElementsWithMaxIndexGivesError.

Temporarily until we have a proper fix.

BUG= chromium:708835 

Change-Id: I9c1d63d8d1f831f2a4a168149b7ff805bc851def
Reviewed-on: https://chromium-review.googlesource.com/469967
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/fa416b18e3903d2f0bb6d7a9b6ac34e3e658b1bc/src/libANGLE/validationES_unittest.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62b2a22982eda9ca564624fed6b24d41cfa4b844

commit 62b2a22982eda9ca564624fed6b24d41cfa4b844
Author: jmadill <jmadill@chromium.org>
Date: Thu Apr 06 19:32:01 2017

Roll ANGLE 60e17ea..fa416b1

https://chromium.googlesource.com/angle/angle.git/+log/60e17ea..fa416b1

BUG= chromium:708835 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2803083002
Cr-Commit-Position: refs/heads/master@{#462583}

[modify] https://crrev.com/62b2a22982eda9ca564624fed6b24d41cfa4b844/DEPS

Status: Fixed (was: Assigned)
The bot is green now.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/03b333b4848de07eb6755f1e9594ef2bb44b752a

commit 03b333b4848de07eb6755f1e9594ef2bb44b752a
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Apr 07 20:32:10 2017

Vulkan: Fix Clang warning and fix build.

The data_deps section for angle_vulkan was referencing a variable
that didn't exist (no warning for this). Fix the deps which also
then exposes the build problem with the layers with Clang in 32-bit.
Also fix not propagating the Win32 defines to the layer utils.

BUG= chromium:708835 

Change-Id: I4a457bfabf1ca735d3f3f3d8b0f0823cfa834b84
Reviewed-on: https://chromium-review.googlesource.com/470087
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/03b333b4848de07eb6755f1e9594ef2bb44b752a/src/vulkan_support/BUILD.gn
[modify] https://crrev.com/03b333b4848de07eb6755f1e9594ef2bb44b752a/gni/angle.gni

Status: Verified (was: Fixed)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c41f41b27d5cf1f0595a0f591cfff06664cbd7d

commit 2c41f41b27d5cf1f0595a0f591cfff06664cbd7d
Author: jmadill <jmadill@chromium.org>
Date: Mon Apr 10 19:40:54 2017

Roll ANGLE bf67aa8..20e005b

https://chromium.googlesource.com/angle/angle.git/+log/bf67aa8..20e005b

BUG= chromium:708835 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2807233002
Cr-Commit-Position: refs/heads/master@{#463366}

[modify] https://crrev.com/2c41f41b27d5cf1f0595a0f591cfff06664cbd7d/DEPS

Sign in to add a comment