New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708824 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix unused strings in ash

Project Member Reported by jamescook@chromium.org, Apr 5 2017

Issue description

tools/check_grd_for_unused_strings.py

IDS_ASH_STATUS_TRAY_DISABLE_WIFI and ENABLE and others

    IDS_ASH_STATUS_TRAY_DISABLE_MOBILE
    IDS_ASH_STATUS_TRAY_ENABLE_MOBILE
    IDS_ASH_STATUS_TRAY_IME_TURNED_ON_BUBBLE
    IDS_ASH_STATUS_TRAY_LOW_POWER_CHARGER_MESSAGE
    IDS_ASH_STATUS_TRAY_MOBILE_VIEW_ACCOUNT
    IDS_ASH_STATUS_TRAY_NETWORK_PROHIBITED_OTHER
    IDS_ASH_STATUS_TRAY_NETWORK_TECHNOLOGY_ENFORCED_BY_POLICY
    IDS_ASH_STATUS_TRAY_OTHER_MOBILE
    IDS_ASH_STATUS_TRAY_SETUP_MOBILE
    IDS_ASH_STATUS_TRAY_THIRD_PARTY_IME_TURNED_ON_BUBBLE
    IDS_ASH_STATUS_TRAY_TURN_ON_WIFI
    IDS_ASH_STATUS_TRAY_VPN_MONITORED
    IDS_CHARGER_REPLACEMENT_ACCESSIBILITY_NOTIFICATION
    IDS_DESKTOP_CASTING_ACTIVE_BUTTON_ABORT_USER_SWITCH
    IDS_DESKTOP_CASTING_ACTIVE_BUTTON_SWITCH_USER
 
Labels: Proj-MaterialDesign-CrOS M-59
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf38158add6214df8d0779816c854429ccc6208e

commit cf38158add6214df8d0779816c854429ccc6208e
Author: jamescook <jamescook@chromium.org>
Date: Thu Apr 06 19:55:11 2017

chromeos: Remove unused strings from ash

Most of them probably became unreferenced in the MD status tray conversion.

BUG= 708824 
TEST=compiles
R=tdanderson@chromium.org
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2803693004
Cr-Commit-Position: refs/heads/master@{#462595}

[modify] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/ash/ash_strings.grd

Components: UI>Shell
Status: Fixed (was: Assigned)
There are more unused strings elsewhere, but ash is clean now.

Sign in to add a comment