OwnerSettingsServiceChromeOS does not wait for private slot initialization |
||||
Issue descriptionowner_settings_service_chromeos.cc calls crypto::GetPrivateSlotForChromeOSUser without specifying a callback to wait for the slot initialization. AFAICT it is assuming that waiting on NOTIFICATION_PROFILE_CREATED and TPMTokenLoader::Get()->IsTPMTokenEnabled is sufficient, but I don't think there is any guarantee that is true.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb330d1b8f803ccb942c7ca2e7e2510c612c1828 commit bb330d1b8f803ccb942c7ca2e7e2510c612c1828 Author: xiyuan <xiyuan@chromium.org> Date: Thu Apr 06 18:49:14 2017 cros: Call GetPrivateSlotForChromeOSUser properly OwnerSettingsServiceChromeOS calls GetPrivateSlotForChromeOSUser without using the callback, assuming the private slot is available after profile load and tpm token ready. The CL changes to use the callback arg of GetPrivateSlotForChromeOSUser so that the code does not depend on the assumption and can properly wait for the slot initialization. BUG= 708823 Review-Url: https://codereview.chromium.org/2796303005 Cr-Commit-Position: refs/heads/master@{#462561} [modify] https://crrev.com/bb330d1b8f803ccb942c7ca2e7e2510c612c1828/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
,
Apr 6 2017
,
May 8 2017
,
May 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by xiy...@chromium.org
, Apr 6 2017Components: UI>Shell>StartScreen
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)