New issue
Advanced search Search tips

Issue 708817 link

Starred by 2 users
Status: Verified
Owner:
hongchan@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

Wrap testharness.js done() method to catch the unexpected test pass.

Project Member Reported by hongchan@chromium.org, Apr 5 2017 
Some tests report 'pass' by testharness when done() is called by mistake. Wrap the done() method and check if Audit's task runner is actually finished.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/897d20df0777854e91b4afab0923e917cd06640a

commit 897d20df0777854e91b4afab0923e917cd06640a
Author: hongchan <hongchan@chromium.org>
Date: Thu Apr 06 23:40:50 2017

Throw when testharness::done() is called by layout test code

This CL wraps done() method in the global scope, which is defined by
testharness.js to prevent a test from finishing prematurely.

2 layout tests are found from this check and fixed accordingly.

BUG= 708817 
TESTS=
webaudio/AudioParam/audioparam-update-value-attribute.html
webaudio/DynamicsCompressor/dynamicscompressor-basic.html

Review-Url: https://codereview.chromium.org/2804103002
Cr-Commit-Position: refs/heads/master@{#462685}

[modify] https://crrev.com/897d20df0777854e91b4afab0923e917cd06640a/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-update-value-attribute.html
[modify] https://crrev.com/897d20df0777854e91b4afab0923e917cd06640a/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-basic.html
[modify] https://crrev.com/897d20df0777854e91b4afab0923e917cd06640a/third_party/WebKit/LayoutTests/webaudio/resources/audit.js

Comment 2 by hongchan@chromium.org, Apr 8 2017

Status: Verified (was: Started)
►

Sign in to add a comment