Remove "open all" commands from Mac bookmarks menus |
||||
Issue descriptionAs shown in attached image: 1. remove open-all-xyz items from the wrench and application menus 2. keep open-all-xyz in context menus from bookmarks-bar itself and on specific bookmarks folders 3. rename the open-all-xyz items to include counts instead of the noun "bookmarks" (will be tracked in a separate bug) 1 and 2 are Mac specific.
,
Apr 6 2017
lgrey@ - do you have some time to make these changes (1 and 2)? I don't think they should take too much work. But maybe land after branch, just in case there are unexpected consequences.
,
Apr 7 2017
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e52938b242948527f56802eb6871cdc65f7a10d7 commit e52938b242948527f56802eb6871cdc65f7a10d7 Author: lgrey <lgrey@chromium.org> Date: Mon Apr 24 17:01:36 2017 [Mac] Remove "Open All Bookmarks" menu items from application and wrench menus BUG= 708813 Review-Url: https://codereview.chromium.org/2804903003 Cr-Commit-Position: refs/heads/master@{#466663} [modify] https://crrev.com/e52938b242948527f56802eb6871cdc65f7a10d7/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm [modify] https://crrev.com/e52938b242948527f56802eb6871cdc65f7a10d7/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge_unittest.mm [modify] https://crrev.com/e52938b242948527f56802eb6871cdc65f7a10d7/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.h [modify] https://crrev.com/e52938b242948527f56802eb6871cdc65f7a10d7/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm [modify] https://crrev.com/e52938b242948527f56802eb6871cdc65f7a10d7/chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller_unittest.mm
,
Apr 25 2017
Confirmed on Canary
,
Aug 14 2017
,
Aug 15 2017
I think this removed a bit too much. I can understand that the 'open-all-xyz' items should not be at the top level of the menus, but please keep them available in sub-folders, even when those sub-folders are accessed from the application or wrench menus.
,
Aug 15 2017
Why the hell would you go and do that?
,
Aug 15 2017
Why would I do what?
,
Aug 15 2017
Clearly the question is for @lgrey. Why would Google go and remove this function?
,
Aug 15 2017
This is a terrible change. I use open-all-xyz daily in various subfolders, and having to go through the bookmark bar now is making me seriously consider changing browsers.
,
Aug 20 2017
I use open-all-xyz multiple times a day. I want this functionality back! I can't imagine why anyone would remove it.
,
Aug 20 2017
This is a terrible change. Why would you remove a feature that people use? Bring back the option, please.
,
Aug 21 2017
Please, please, please, please give us this feature back. It is essential to my daily workflow.
,
Aug 21 2017
I opened an issue to restore this functionality. Please vote here: https://bugs.chromium.org/p/chromium/issues/detail?id=757449&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=
,
Aug 21 2017
Hi @lgrey, what about the question about *WHY* would Google go and remove this function?
,
Aug 22 2017
What was the rational behind this decision? My user experience is negatively affected and I my productivity slowed down because of this.
,
Aug 23 2017
I agree that it is a very bad decision to simply remove this menu item. I used this feature every day.
,
Aug 25 2017
Item 1 is a horrible change for me. Please undo it. What were you people thinking, or more likely were you NOT thinking?
,
Aug 27 2017
ok, so you are removing features which have low usage? even though you could easily put a flag to restore it, or allow it to be configurable? So ok, whilst we are at it, lets remove the following too 1) the people menu, since I reckon barely anybody other than power users use that 2) Remove the email page location menu item, since I reckon nobody uses that either 3) Remove the import bookmarks and settings menu item, since how many times a day is that used? I have never used this feature a single time, I reckon its common for nobody to use it, even if they do, they'll use it once and they're done with 4) who saves pages to their computer anymore? I reckon nobody, since it was a feature since the netscape days, nobody seriously expects to save a webpage to their computer with all that ajax around 5) start dictation? why would I want to do that? who does that in the first place? why is this option even there? remove that too I mean, my point is that just because its a feature that you dont use and has low usage, doesnt mean its not useful and how do you know I even use that feature since I dont send telemetry to google and neither does anybody else about what buttons they are clicking in the browser, so how do you even have accurate information about how much those buttons are used, you simple, do, not, have, accurate, data, end of story. Then when we complain cause you are screwing with our daily workflows over some trivial issue which does not make the browser any better btw, I mean, its not like its a faster browsing experience, or uses less memory, or has more features which are useful to me, or supports more css or javascript improvements, this is a trivial change that probably is delegated to a user interface team who dont have a lot of work, since chrome never changes its user interface that often. So why remove it? and why not just give us an option to turn it back on, because if your silly reasoning about how its low usage when you clearly cannot have the data to know that, is your only justification, then lets go through my list above and start stripping out those features too, cause my reasoning for the above list is bogus and therefore so is yours. Good Day.
,
Aug 28 2017
I also agree this was a terrible decision. That feature was a critical component in how I used Bookmarks in Chrome. I know of no good reason to remove it. Please bring it back!
,
Aug 29 2017
Bring it back.
,
Sep 7 2017
This was not a bug, it actually was a feature. Status should now read: BROKEN
,
Oct 6
Is this related to why Command-click on a bookmark folder no longer performs an open all in tabs any more? If so, agreed this should now be marked as Broken.
,
Oct 8
Command-click to open all was broken at some point, but I'm pretty sure that never shipped to stable. It works for me in 69.0.3497.100. If it's not working for you, please file a new bug with details. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rpop@chromium.org
, Apr 5 2017