New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708808 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update chromecast code to use media::VideoColorSpace

Project Member Reported by servolk@chromium.org, Apr 5 2017

Issue description

Chromecast HDR code is using VideoDecoderConfig::color_space_info, which used to be gfx::ColorSpace, but I can see that hubbe@ introduced a new media::VideoColorSpace struct in https://codereview.chromium.org/2742113002. We'll need to update a couple of places in Chromecast code, but this should allow us to get rid of some local (downstream) patches in Cast code base.

 

Comment 1 by hubbe@chromium.org, Apr 5 2017

Note that VideoColorSpace is not meant to be attached to videoframes, textures or other renderable things, as there is a much wider variety of color spaces possible for such things.  VideoColorSpace is only meant to be used to describe the color spaces find in video files and similar.


Yes, we currently support only static HDR metadata for Chromecast and so we are not attaching VideoColorSpace to individual video frames. We are using the VideoColorSpace included into the VideoDecoderConfig to properly initialize our hardware decoder pipeline.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b44ee0e7a402cbc927a59c15e2ab3fe1b9ac938a

commit b44ee0e7a402cbc927a59c15e2ab3fe1b9ac938a
Author: servolk <servolk@chromium.org>
Date: Wed Apr 12 22:39:21 2017

Fix Mojo IPC for HDR metadata

BUG= 708808 

Review-Url: https://codereview.chromium.org/2815953002
Cr-Commit-Position: refs/heads/master@{#464181}

[modify] https://crrev.com/b44ee0e7a402cbc927a59c15e2ab3fe1b9ac938a/media/mojo/interfaces/hdr_metadata_struct_traits.h

Status: Fixed (was: Started)

Sign in to add a comment