Disconnected method names between SnapshotController and Offliners |
||
Issue descriptionSnapshotController's documentation indicate that it's expecting DocumentAvailableInMainFrame and DocumentOnLoadCompletedInMainFrame from WebContentsObserver. However, we are calling those methods from DocumentLoadedInFrame and DidStopLoading inside PrerenderingLoader and BackgroundLoaderOffliner. We should either update the SnapshotController to be same as the Offliner or update the Offliners to pass on the correct signal
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c92ef59a640cf2dacabef34f8cf798e39c1e61f5 commit c92ef59a640cf2dacabef34f8cf798e39c1e61f5 Author: chili <chili@chromium.org> Date: Tue Apr 11 21:44:16 2017 [Offline pages] Update background loader to override the WebContentsObserver methods expected by the SnapshotController. Note that while the same issue exists for prerendering loader, we are not going to update that. BUG= 708798 Review-Url: https://codereview.chromium.org/2797013002 Cr-Commit-Position: refs/heads/master@{#463782} [modify] https://crrev.com/c92ef59a640cf2dacabef34f8cf798e39c1e61f5/chrome/browser/android/offline_pages/background_loader_offliner.cc [modify] https://crrev.com/c92ef59a640cf2dacabef34f8cf798e39c1e61f5/chrome/browser/android/offline_pages/background_loader_offliner.h [modify] https://crrev.com/c92ef59a640cf2dacabef34f8cf798e39c1e61f5/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
,
Apr 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chili@chromium.org
, Apr 8 2017