New issue
Advanced search Search tips

Issue 708778 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

resources/late-start-testing.js not really needed

Project Member Reported by rtoy@chromium.org, Apr 5 2017

Issue description

This file is used in exactly one place. The contents should just be moved to oscillator-late-start.html.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd42497e9d8fe45ff487d58ac184130bd9ee802d

commit fd42497e9d8fe45ff487d58ac184130bd9ee802d
Author: rtoy <rtoy@chromium.org>
Date: Sat Apr 22 00:03:19 2017

Move late-start-testing.js to only user

The code in resources/late-start-testing.js is used in only one
place.  Move that code into the one place.

The tests were updated to be more thorough in verifying that the
initial part is 0, and the first non-zero follows right after.

BUG= 708778 
TEST=oscillator-late-start.html

Review-Url: https://codereview.chromium.org/2810413004
Cr-Commit-Position: refs/heads/master@{#466502}

[modify] https://crrev.com/fd42497e9d8fe45ff487d58ac184130bd9ee802d/third_party/WebKit/LayoutTests/webaudio/Oscillator/oscillator-late-start.html
[delete] https://crrev.com/99bba8891981903c3089d5780d603b164086650d/third_party/WebKit/LayoutTests/webaudio/resources/late-start-testing.js

Comment 2 by rtoy@chromium.org, Apr 24 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment