CC jif@ -

Are clipboard URL suggestions shown in incognito on iOS?

It appears that no forms of on-focus suggest get shown in incognito mode in Android, not even Most Visited suggestions.

mariakhomenko@, do you recall if this was an internal design decision?

Clipboard URL suggestions are shown in Incognito on iOS. Privacy didn't have any problem with this.

Thank you Jif@.

For Android zero suggest, this was an intentional design decision.

I think it made sense to us, there is no most visited on incognito NTP either. Other forms of zero suggest make server requests.

mariakhomenko: since clipboard doesn't make server requests, though, would there be any objection to changing this? 

I synced with Maria by chat about this.  Privacy has already approved; the next step is product approval.  I'll talk with Emily.

Check with Emily; she's fine with it.  She'll chat with other folks to see if anyone has concerns.  (We don't expect any.)

Note to self: here is likely the magical line that disable zero suggest entirely in incognito on Android:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java?l=1108

When revising this line, remember to add the analogous off-the-record test to zero suggest provider.  No other providers need changing.  (I audited them.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eaf7fc310350fba0b59738040d6f97b640d553e

commit 6eaf7fc310350fba0b59738040d6f97b640d553e
Author: mpearson <mpearson@chromium.org>
Date: Tue Apr 11 04:09:57 2017

Omnibox - Allow On-Focus Suggestions on Android Incognito

Instead of a blanket prohibition, each provider can make its own
decisions about when to trigger and when not to.

Currently I believe the only provider that will sometimes trigger is
clipboard URL provider.

BUG= 708774 

Review-Url: https://codereview.chromium.org/2812793002
Cr-Commit-Position: refs/heads/master@{#463528}

[modify] https://crrev.com/6eaf7fc310350fba0b59738040d6f97b640d553e/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/6eaf7fc310350fba0b59738040d6f97b640d553e/components/omnibox/browser/zero_suggest_provider.cc