New issue
Advanced search Search tips

Issue 708773 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

WebView doesn't set process type to renderer in renderer process crashes.

Project Member Reported by tobiasjs@chromium.org, Apr 5 2017

Issue description

Microdumps in multiprocess mode are always "browser", regardless of which process crashed.

Issue is here: https://cs.chromium.org/chromium/src/android_webview/lib/main/aw_main_delegate.cc?rcl=dee02108c6c8a064f04bbbb214c07c60cb48f48c&l=212

 

Comment 1 by torne@chromium.org, Apr 5 2017

Hm, but isn't that code only run in the browser process? I wouldn't expect PreSandboxStartup to run in renderers.

Comment 2 by boliu@chromium.org, Apr 5 2017

MainDelegate code generally runs on all processes. I don't know specifically about PreSandboxStartup though, but from the sound of the name, maybe it should *only* run in child processes..?

Comment 3 by torne@chromium.org, Apr 5 2017

Yeah actually looking at content_main_runner, it runs in all processes, and the name is pretty irrelevant on Linux because the sandbox is not actually started in content_main_runner anyway (so PreSandboxStartup is immediately followed by SandboxInitialized without anything happening inbetween).
Although that code does run in browser and renderer processes, I was to hasty about calling that out as the location of the problem. At that point the process type is actually correct (it needs to be, otherwise setting up the renderer signal pipe wouldn't work).
Predominantly the problem is that we currently mark single process crashes with "browser", not "webview". Almost none of the observed webview crashes are in multiprocess mode (I guess not many N users have enabled it) so the lack of renderer crashes is almost entirely down to the fact that there are almost no multiprocess crashes.

Apart from the multiprocess issue, there's a secondary problem with ptype, which is that it is regexed out of the logs, and the match is not necessarily in the microdump that ends up being symbolized.

Labels: Merge-Request-58
Project Member

Comment 8 by sheriffbot@chromium.org, Apr 11 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Android
Labels: -Hotlist-Merge-Review -Merge-Review-58
Status: Fixed (was: Assigned)

Sign in to add a comment