Here are some instances of .force_update_firmware

https://cs.corp.google.com/search/?q=.force_update_firmware&sq=package:%5Echromeos_(internal%7Cpublic)$&type=cs

I cannot see that it is used anywhere. Can I drop it?

CROS_FIRMWARE_FORCE_UPDATE was introduced for developers and testers to build a release image that can be auto-updated with firmware updater executed, without needing to run sign_official build.

+dchan

Danny, does test team still use CROS_FIRMWARE_FORCE_UPDATE in your process to test AU + firmware updates? If not, I think we can really drop it.

CROS_FIRMWARE_FLASHROM_BINARY was introduced because we had to support proprietary or special local build version of flashrom at that time, but I think this is no longer needed.

And yes, CROS_FIRMWARE_EC_VERSION should be deprecated after Pineview sunset.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c0f4b46a57ddacc435a83bb0a09a2d9e5e4c37a7

commit c0f4b46a57ddacc435a83bb0a09a2d9e5e4c37a7
Author: Simon Glass <sjg@chromium.org>
Date: Fri Apr 07 17:02:02 2017

cros-firmware: Deprecate CROS_FIRMWARE_EC_VERSION

This variable is only used on zgb. Mark it as deprecated.

BUG= chromium:708772 
TEST=Check using code search that this is not used anywhere else
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I81b577e55a523426b0e9bb5744a913469bbaf931
Reviewed-on: https://chromium-review.googlesource.com/470408
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/c0f4b46a57ddacc435a83bb0a09a2d9e5e4c37a7/eclass/cros-firmware.eclass

Danny can you please check #2?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/aad3bcf85d2e593e55c4f2589aab767e434775b9

commit aad3bcf85d2e593e55c4f2589aab767e434775b9
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 12 06:25:58 2017

cros-firmware: Drop CROS_FIRMWARE_FLASHROM_BINARY

This is not used in Chrome OS. Drop it.

BUG= chromium:708772 
TEST=Check using code search that this is not used

Change-Id: Idf1252dc658155a93f38ce503680e0a60129dd5e
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/470410
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/aad3bcf85d2e593e55c4f2589aab767e434775b9/eclass/cros-firmware.eclass

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7d7500808a366fb75520310eb698d5ba60285962

commit 7d7500808a366fb75520310eb698d5ba60285962
Author: Simon Glass <sjg@chromium.org>
Date: Tue Apr 25 21:03:48 2017

cros-firmware: Drop CROS_FIRMWARE_FORCE_UPDATE

This is not used in Chrome OS. Drop it.

BUG= chromium:708772 
TEST=Check using code search that this is not used anywhere
Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: I1988ff1549b83fbe10c701114d362a708977dfc2
Reviewed-on: https://chromium-review.googlesource.com/470409
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: danny chan <dchan@chromium.org>

[modify] https://crrev.com/7d7500808a366fb75520310eb698d5ba60285962/eclass/cros-firmware.eclass

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c300bb1891cd8b9c2e8c92ce3cf862c4c5a9f7be

commit c300bb1891cd8b9c2e8c92ce3cf862c4c5a9f7be
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 26 16:21:09 2017

cros-firmware: Drop use of old firmware script

Now that we have the Python replacement we can drop the shell script.

BUG= chromium:708772 
TEST=emerge-reef chromeos-firmware-reef
Change-Id: Ifb39d6282388810a3ea97068728d4543c960c1a3
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/486134
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/c300bb1891cd8b9c2e8c92ce3cf862c4c5a9f7be/eclass/cros-firmware.eclass

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/6761a7ffbd06c27f12b1cb51b09ce15a7488d299

commit 6761a7ffbd06c27f12b1cb51b09ce15a7488d299
Author: Simon Glass <sjg@chromium.org>
Date: Fri Apr 28 21:16:10 2017

Drop the old pack_firmware script

This has been replaced with the Python version now.

BUG= chromium:708772 
TEST=emerge-reef chromeos-firmware-reef
Change-Id: Idc3753ef6de8f5a40a3ac756b0663808434fa5a1
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/486273
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[delete] https://crrev.com/88faa1769b36ea4a51ea66e06416fedeadafa7af/pack_firmware.sh
[modify] https://crrev.com/6761a7ffbd06c27f12b1cb51b09ce15a7488d299/pack_firmware.py
[modify] https://crrev.com/6761a7ffbd06c27f12b1cb51b09ce15a7488d299/README.md
[modify] https://crrev.com/6761a7ffbd06c27f12b1cb51b09ce15a7488d299/PRESUBMIT.cfg

Pineview EOL has been done. Feel free to remove CROS_FIRMWARE_EC_VERSION.

Actually I can now remove CROS_FIRMWARE_EC_VERSION also.

Thanks Hung-te

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea98b54da26a8c049a762736ddbc5c954904c573

commit ea98b54da26a8c049a762736ddbc5c954904c573
Author: Simon Glass <sjg@chromium.org>
Date: Tue May 02 18:45:40 2017

cros-firmware: Drop CROS_FIRMWARE_EC_VERSION

With the removal of very old firmware updates (pineview) this feature is
no-longer used. Drop it.

BUG= chromium:708772 
TEST=search in Chrome OS source code for CROS_FIRMWARE_EC_VERSION

Change-Id: Ibdeea6c9bd2cbaa4143d1f316bd5973f4575752d
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/491250
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/ea98b54da26a8c049a762736ddbc5c954904c573/chromeos-base/chromeos-firmware-null/chromeos-firmware-null-9999.ebuild
[modify] https://crrev.com/ea98b54da26a8c049a762736ddbc5c954904c573/eclass/cros-firmware.eclass

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/07a7298607ee2d81fb576ae5f97110caf834d772

commit 07a7298607ee2d81fb576ae5f97110caf834d772
Author: Simon Glass <sjg@chromium.org>
Date: Wed May 03 03:24:14 2017

pack_firmware: Drop support for --ec_version

This feature is not used in cros-firmware.eclass anymore, since the
pineview deprecation. Drop it.

BUG= chromium:708772 
TEST=PYTHONPATH=~/cosarm python pack_firmware_functest.py

Change-Id: Id1b72654009384ebbef5eb9ae3b1dcd0b68d33c2
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/491647
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/07a7298607ee2d81fb576ae5f97110caf834d772/pack_firmware.py