New issue
Advanced search Search tips

Issue 708759 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 622387
Owner:
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

DumpAccessibilityTreeTest.AccessibilityAomChecked failing on chromium.memory/Linux TSan Tests

Project Member Reported by kelv...@chromium.org, Apr 5 2017

Issue description

Culprit
https://codereview.chromium.org/2787843003

Root Cause:
The function RunAomTest try to override the global feature list after
it is setup, causing a race condition with a read from the network thread.

Possible fix:
The browser test should override SetUpOnMainThread() or SetUpInProcessBrowserTestFixture() and set up the
feature list there instead.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eb8350b9a05a09b216f684155b7423bd4716084

commit 6eb8350b9a05a09b216f684155b7423bd4716084
Author: kelvinp <kelvinp@chromium.org>
Date: Wed Apr 05 22:45:33 2017

Disable DumpAccessibilityTreeTest.AccessibilityAomChecked  on TSAN

Failures:
https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests/builds/3704

Root cause:
https://codereview.chromium.org/2787843003
RunAomTest() try to override the global feature list after the browser
test is setup, causing a race condition with a read from the network
thread.

BUG= 708759 
TBR=dmazzoni

Review-Url: https://codereview.chromium.org/2797363002
Cr-Commit-Position: refs/heads/master@{#462252}

[modify] https://crrev.com/6eb8350b9a05a09b216f684155b7423bd4716084/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Mergedinto: 622387
Status: Duplicate (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbfb0cf6999a682e226afb80f5e590c42873fc6b

commit fbfb0cf6999a682e226afb80f5e590c42873fc6b
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Feb 26 22:17:42 2018

AOM content_browsertests can be re-enabled, the tsan bug was addressed.

Bug:  708759 
Change-Id: I70bf3f5d7fdb6e4e9dded28d34751fd8a3ee02db
Tbr: aboxhall@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/938153
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539284}
[modify] https://crrev.com/fbfb0cf6999a682e226afb80f5e590c42873fc6b/content/browser/accessibility/dump_accessibility_tree_browsertest.cc

Sign in to add a comment