New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708740 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

mojo InterfaceProviderSpec should use flat_map

Project Member Reported by brettw@chromium.org, Apr 5 2017

Issue description

I'm seeing a lot of temporary memory use (i.e. churn rather than a leak) in my memory analysis related to hash tables of InterfaceProviderSpecs.

From my understanding, all maps and sets declared in interface_provider_spec.h are good candidates for using base::flat_map and base::flat_set.

I started trying to convert them but ran into lots of serialization goop that was more work than I had time for.

If somebody looks into this, please check with me about serialization as we want to avoid creation of flat_maps one-element-at-a-time.
 
Labels: Performance-Memory

Comment 2 by roc...@chromium.org, Apr 10 2017

Cc: -roc...@chromium.org
Owner: roc...@chromium.org
Status: Assigned (was: Untriaged)
I'll look at this at some point.

Comment 3 by roc...@chromium.org, May 29 2017

Cc: roc...@chromium.org
Components: -Internals>Mojo Internals>ServiceManager
Owner: ----
Status: Available (was: Assigned)

Comment 4 by laforge@google.com, Nov 1 2017

Components: -Internals>ServiceManager Internals>Services>ServiceManager
Status: WontFix (was: Available)
No longer relevant since we'll be deleting InterfaceProviderSpec.

Sign in to add a comment