Handle Capabilities retrieval failure gracefully |
||||
Issue descriptionIf capabilities retrieval fails in the print preview dialog, the entire dialog falls into an error state and can't be used until reopened. Handle the failure more gracefully and allow other printers to be chosen.
,
Apr 11 2017
,
Apr 18 2017
,
May 2 2017
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f commit d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f Author: skau <skau@chromium.org> Date: Tue May 02 22:27:32 2017 Process null capabilities as a capability fetch failure. We can never do anything if a request for printer capabilities returns null. Thus, assert that it's non-null and call the failure code if capabilities is null. This also fixes PrintPreviewDestinationSearchTest.Select which has been failing on the Linux MSan buildbot sporadically. BUG= 708739 , 716595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848093002 Cr-Commit-Position: refs/heads/master@{#468794} [modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/browser/resources/print_preview/native_layer.js [modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/d61afbf71f7ccea7bf8b2e5632e3f3d052a7813f/chrome/test/data/webui/print_preview_destination_search_test.js |
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Apr 5 2017