New issue
Advanced search Search tips

Issue 708737 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Add autotest for mushrome test

Project Member Reported by sky@chromium.org, Apr 5 2017

Issue description

This should be roughly the same as the mash test, but should launch mushrome.
 
Tips:
* You might want to add this test to the existing desktopui_MashLogin tests rather than adding a new autotest. Autotests can be very slow because they involve deploying scripts to the device each run. Unlike unit tests we often tolerate tests being bigger and doing multiple things.
* desktopui_MashLogin is in https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/desktopui_MashLogin/desktopui_MashLogin.py?q=desktopui_MashLogin&sq=package:%5Echromeos_public$&l=11
* You have to have a Chrome OS checkout to work on the tests
* There's a hacky way to iterate on the test without deploying it each time, ping me for details
* My go-to people for autotest questions are achuith, ihf, xiyuan. There's also the internal chrome os infrastructure mailing list.

Cc: mustash-autotest-bugs@google.com
Test CC.

Status: Assigned (was: Untriaged)
Owner: kylec...@chromium.org
An autotest that does --mus passes on link for me. I'll try and add it bvt-perbuild to see what happens.
Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6b82663bbadc80d898e4978ffd0035578ed88d8c

commit 6b82663bbadc80d898e4978ffd0035578ed88d8c
Author: kylechar <kylechar@chromium.org>
Date: Sat May 06 01:29:02 2017

autotest: Add desktopui_MusLogin to bvt-perbuild.

Add a new test desktopui_MusLogin to the informational bvt-perbuild.
This test is similar to desktopui_MashLogin except it tests "./chrome
--mus" instead of "./chrome --mash."

BUG= chromium:708737 
TEST=Ran autotest on board link.

Change-Id: I18b8da2a1f7e81584d43a3f66d78e067a8dad394
Reviewed-on: https://chromium-review.googlesource.com/497907
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Kyle Charbonneau <kylechar@chromium.org>

[add] https://crrev.com/6b82663bbadc80d898e4978ffd0035578ed88d8c/client/site_tests/desktopui_MusLogin/desktopui_MusLogin.py
[add] https://crrev.com/6b82663bbadc80d898e4978ffd0035578ed88d8c/client/site_tests/desktopui_MusLogin/control

Project Member

Comment 7 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/14dfe062729c37fe23bf7d5876d3fe08361a4485

commit 14dfe062729c37fe23bf7d5876d3fe08361a4485
Author: kylechar <kylechar@chromium.org>
Date: Mon May 08 19:40:59 2017

autotest: Add desktopui_MusLogin to bvt-perbuild.

Add a new test desktopui_MusLogin to the informational bvt-perbuild.
This test is similar to desktopui_MashLogin except it tests "./chrome
--mus" instead of "./chrome --mash."

BUG= chromium:708737 
TEST=Ran autotest on board link.

Change-Id: I7f6c74b9012c8fbf36b546e03e5f508a31d133a8
Reviewed-on: https://chromium-review.googlesource.com/497967
Commit-Ready: Kyle Charbonneau <kylechar@chromium.org>
Tested-by: Kyle Charbonneau <kylechar@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/14dfe062729c37fe23bf7d5876d3fe08361a4485/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild

Comment 8 by ihf@chromium.org, May 9 2017

Check here for the test results (may take a day or two)
https://wmatrix.googleplex.com/unfiltered?hide_missing=True&releases=tot&tests=desktopui_MusLogin
Status: Fixed (was: Assigned)
Thanks for the help ihf. I see test results, marking as fixed.
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment