ContentViewCore creation doesn't set initial focus state correctly. |
||||
Issue descriptionWhile working on issue 686232 I noticed that the initial state for Window Focus and View Focus weren't being set correctly when creating a ContentViewCore, or replacing its ContainerView.
,
Apr 5 2017
Marking as fixed, but noting for posterity that there may be outstanding issues around View#hasWindowFocus doing baffling things like returning true after onWindowFocusChanged(false) is called.
,
Apr 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a4822cef0d01331ae273a70752341b45f654802 commit 7a4822cef0d01331ae273a70752341b45f654802 Author: aelias <aelias@chromium.org> Date: Sat Apr 08 01:03:53 2017 Revert "Ensure initial focus is set properly when creating a ContentViewCore" Also revert dependent patch: Revert "Fix crash in ContentViewCore#onResolveTapDisambiguation due to null ContainerView" This patch introduced null pointer crashes. NOTRY=true TBR=mthiesse@chromium.org BUG=709361,708733 Review-Url: https://codereview.chromium.org/2805323003 Cr-Commit-Position: refs/heads/master@{#463088} [modify] https://crrev.com/7a4822cef0d01331ae273a70752341b45f654802/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/7a4822cef0d01331ae273a70752341b45f654802/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java [modify] https://crrev.com/7a4822cef0d01331ae273a70752341b45f654802/content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java
,
Apr 11 2017
Given the complexity around this change, and the lack of testing, I don't think it makes sense to try to re-land this until it solves any known issues. Let me know if you violently disagree and I'll try to re-land.
,
Apr 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Apr 5 2017