New issue
Advanced search Search tips

Issue 708723 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature

Blocked on:
issue 543997
issue 700607

Blocking:
issue 338503



Sign in to add a comment

Finish implementing MediaTrackConstraint support in Image Capture

Project Member Reported by mcasas@chromium.org, Apr 5 2017

Issue description

This is a follow-up to  https://crbug.com/700607  to track finishing
implementing support for MediaTrackConstraint for image capture. (More 
details coming).
 
Blockedon: 700607
This includes supporting sophisticated constraints (such as, e.g. 
ConstrainDOMStringParameters) and supporting more than one 
|advanced| constraint vector entry, both in method [1].

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp?type=cs&q=ImageCapture::setMediaTrackConstraints&l=251
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5b6a1cd0258c12363b53f0d382471141463abe

commit 1d5b6a1cd0258c12363b53f0d382471141463abe
Author: mcasas <mcasas@chromium.org>
Date: Thu Apr 06 17:31:29 2017

Image Capture: make sure applyConstraints() only works for ImageCapture constraints

This CL:
 - makes sure MediaStreamTrack::applyConstraints() is rejected if non
 image-capture related constraints are passed; (this follows the
 Spec e.g. in [1], " If the constraints cannot be applied, the promise is
 rejected").

- generally cleans up  MediaStreamTrack::applyConstraints() moving
 part of the TODO()s to Image Capture so that they are in the
 same place (facilitates later reviews).

 - derives to clearMediaTrackConstraints() if the constraint set is
 empty, after spec issue somehow clarified it

LayoutTests updated/extended.

[1] https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstraints#Return_value

BUG= 700607 , 708723

Review-Url: https://codereview.chromium.org/2804653003
Cr-Commit-Position: refs/heads/master@{#462531}

[modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-applyConstraints.html
[modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getConstraints.html
[modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
[modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

Comment 4 by mcasas@chromium.org, May 11 2017

Labels: Pri-3
Status: Untriaged (was: Assigned)
Removing myself as owner of these issues are marking them 
for retriaging.
Owner: ----
Blocking: 338503
Labels: Hotlist-Interop OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows

Comment 9 by mcasas@chromium.org, Oct 23 2017

Status: Available (was: Untriaged)
Cc: -guidou@chromium.org
Components: Blink>MediaStream
Owner: guidou@chromium.org
Cc: -foolip@chromium.org
Status: Assigned (was: Available)

Sign in to add a comment