Finish implementing MediaTrackConstraint support in Image Capture |
||||||||||
Issue descriptionThis is a follow-up to https://crbug.com/700607 to track finishing implementing support for MediaTrackConstraint for image capture. (More details coming).
,
Apr 5 2017
This includes supporting sophisticated constraints (such as, e.g. ConstrainDOMStringParameters) and supporting more than one |advanced| constraint vector entry, both in method [1]. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp?type=cs&q=ImageCapture::setMediaTrackConstraints&l=251
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d5b6a1cd0258c12363b53f0d382471141463abe commit 1d5b6a1cd0258c12363b53f0d382471141463abe Author: mcasas <mcasas@chromium.org> Date: Thu Apr 06 17:31:29 2017 Image Capture: make sure applyConstraints() only works for ImageCapture constraints This CL: - makes sure MediaStreamTrack::applyConstraints() is rejected if non image-capture related constraints are passed; (this follows the Spec e.g. in [1], " If the constraints cannot be applied, the promise is rejected"). - generally cleans up MediaStreamTrack::applyConstraints() moving part of the TODO()s to Image Capture so that they are in the same place (facilitates later reviews). - derives to clearMediaTrackConstraints() if the constraint set is empty, after spec issue somehow clarified it LayoutTests updated/extended. [1] https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstraints#Return_value BUG= 700607 , 708723 Review-Url: https://codereview.chromium.org/2804653003 Cr-Commit-Position: refs/heads/master@{#462531} [modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-applyConstraints.html [modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/LayoutTests/fast/imagecapture/MediaStreamTrack-getConstraints.html [modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp [modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h [modify] https://crrev.com/1d5b6a1cd0258c12363b53f0d382471141463abe/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
,
May 11 2017
,
Sep 5 2017
Removing myself as owner of these issues are marking them for retriaging.
,
Sep 5 2017
,
Sep 8 2017
,
Sep 9 2017
,
Oct 23 2017
,
Oct 23 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f447acc481e3277bed61e2bb6d308b4d36362ce commit 5f447acc481e3277bed61e2bb6d308b4d36362ce Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Oct 25 20:31:02 2017 Make MediaStreamTrack.applyConstraints resolve its promise with void. This is a spec-compliance change. Bug: 708723 Change-Id: I36f7405b259013d731ecc028dcc55c75c8c26620 Reviewed-on: https://chromium-review.googlesource.com/727986 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#511571} [modify] https://crrev.com/5f447acc481e3277bed61e2bb6d308b4d36362ce/content/test/data/media/image_capture_test.html [modify] https://crrev.com/5f447acc481e3277bed61e2bb6d308b4d36362ce/third_party/WebKit/LayoutTests/imagecapture/MediaStreamTrack-applyConstraints.html [modify] https://crrev.com/5f447acc481e3277bed61e2bb6d308b4d36362ce/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp [modify] https://crrev.com/5f447acc481e3277bed61e2bb6d308b4d36362ce/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h [modify] https://crrev.com/5f447acc481e3277bed61e2bb6d308b4d36362ce/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
,
Nov 21 2017
,
Aug 1
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by mcasas@chromium.org
, Apr 5 2017