New issue
Advanced search Search tips

Issue 708719 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 689992



Sign in to add a comment

Android UI needs a utility for setting width dynamically based on strings

Project Member Reported by csharrison@chromium.org, Apr 5 2017

Issue description

SubresourceFilterExperimentalInfoBar needs to include a button which switches between two bits of text.

We need to make sure that the button is sized to fit both pieces of text, so it doesn't grow / shrink when the text changes.

See https://codereview.chromium.org/2791843002/ for a bit more context.

According to dfalcantara there is another component which needs this functionality too.
 
Blocking: 701859
Blocking: 689992
Cc: -dfalcant...@chromium.org
Owner: dfalcant...@chromium.org
Status: Assigned (was: Untriaged)
Hey Dan, any update on this issue?
None.  Debating tackling it soon.  Did you have any status changes on your end for this?
We're planning on shipping with the UI that needs this in M61, but I think this can be a non-blocking bug (at least, in my opinion).

Our current approach uses the max Ems of the two strings, but I am not sure of all the situations where that will be insufficient.
Blocking: -701859
Yeah, the use case we had for this turned out to be unnecessary, so this fell by the wayside.

If the fix you had on your side turns out to be insufficient, it'll eventually show up in the feedback, I suppose.
Do you have an intuition for languages whose character width is drastically different from an em?

Another solution for us would be to precompute the max width based on our language set, since the two strings are static.
Maybe Arabic or other languages where multiple "characters" can be condensed down into a single one?

Hindi also, maybe?
https://en.wikibooks.org/wiki/Hindi/Consonant_combinations
Owner: ----
Status: WontFix (was: Assigned)
Marking WontFix because I'm clocking out and I don't not sure anyone wants to devote cycles to this.

Sign in to add a comment