New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 708705 link

Starred by 1 user
Status: Fixed
Owner:
kylixrd@chromium.org
Closed: Apr 2017
Cc:
brucedaw...@chromium.org
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

GN generated Visual Studio project files (vcxproj) don't properly "escape" certain characters.

Project Member Reported by kylixrd@chromium.org, Apr 5 2017 
Chrome Version: Current
OS: Windows

The content of <PreprocessorDefinitions> cannot contain '\n\r\t"<>&" characters without being "escaped" using the &xxx; sequence.

What is the expected result?

vcxproj files load without error.

What happens instead?

vcxproj files fail to load.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dbbea4c0d8e6f34a12ab7ce3b4a92d36e25d2f8

commit 7dbbea4c0d8e6f34a12ab7ce3b4a92d36e25d2f8
Author: kylixrd <kylixrd@chromium.org>
Date: Fri Apr 07 19:40:38 2017

"Escape" certain characters

Added EscapeString() to convert certain characters into XML escape (&xxx;) sequences

BUG= 708705 

Review-Url: https://codereview.chromium.org/2803613003
Cr-Commit-Position: refs/heads/master@{#462966}

[modify] https://crrev.com/7dbbea4c0d8e6f34a12ab7ce3b4a92d36e25d2f8/tools/gn/visual_studio_writer.cc

Comment 3 by kylixrd@chromium.org, Apr 17 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment