New issue
Advanced search Search tips

Issue 708704 link

Starred by 1 user
Status: Fixed
Owner:
rdevlin....@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

touching chrome/common/extensions/api/tts.json doesn't trigger a recompile

Project Member Reported by rdevlin....@chromium.org, Apr 5 2017 
What steps will reproduce the problem?
1. Build chrome
2. touch chrome/common/extensions/api/tts.json
3. Try to rebuild

What is the expected result?
Build should change.

What happens instead of that?
No work to do

This is bad, because it means that changes that rely on these apis rebuilding from the json file can cause bot failures when they don't.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19329f51423819645c51d444e38b1aa331c3043d

commit 19329f51423819645c51d444e38b1aa331c3043d
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Apr 05 19:53:44 2017

[Extensions] Fix json_schema_api inputs

uncompiled_bundle_schema_sources weren't being properly taken into
account for inputs. Add them.

BUG= 708704 
TEST=Build chrome; touch chrome/common/extensions/api/tts.json,
     build chrome again. It should rebuild.

Review-Url: https://codereview.chromium.org/2798103002
Cr-Commit-Position: refs/heads/master@{#462189}

[modify] https://crrev.com/19329f51423819645c51d444e38b1aa331c3043d/tools/json_schema_compiler/json_schema_api.gni

Comment 2 by rdevlin....@chromium.org, Apr 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment