New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Rename offline_page_metadata_store_impl_unittest.cc

Project Member Reported by romax@chromium.org, Apr 5 2017

Issue description

The name should probably renamed to *_sql_unittest.cc
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998900e47a56f7d307b03705b315591d768512d9

commit 998900e47a56f7d307b03705b315591d768512d9
Author: romax <romax@chromium.org>
Date: Wed Apr 26 05:27:19 2017

[Offline Pages] Renaming metadata store test file.

Renaming the file since we no longer have the in-memory implementation of
the metadata store. Also removing the cc file for the header and moved
the destructor into the header file.

BUG= 708700 

Review-Url: https://codereview.chromium.org/2819983003
Cr-Commit-Position: refs/heads/master@{#467244}

[modify] https://crrev.com/998900e47a56f7d307b03705b315591d768512d9/components/offline_pages/core/BUILD.gn
[delete] https://crrev.com/51ad943c5fac355ab0166e1f47a104e8bc0b3bc6/components/offline_pages/core/offline_page_metadata_store.cc
[modify] https://crrev.com/998900e47a56f7d307b03705b315591d768512d9/components/offline_pages/core/offline_page_metadata_store.h
[rename] https://crrev.com/998900e47a56f7d307b03705b315591d768512d9/components/offline_pages/core/offline_page_metadata_store_unittest.cc

Comment 2 by romax@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)

Sign in to add a comment