New issue
Advanced search Search tips

Issue 708697 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 690423



Sign in to add a comment

Entity suggest should display the entity title

Project Member Reported by jdonnelly@chromium.org, Apr 5 2017

Issue description

In the new entity suggest UI on iOS and desktop, the query text is being displayed (see attached iOS screenshot which shows "roosevelt" and "roosevelt). Instead, we should show the entity title (as on Android, see other attached screenshot, which shows "Franklin D. Roosevelt" and "Theodore Roosevelt".

krb: I can take care of any required iOS changes once you determine the correct approach.
 
IMG_0003.PNG
86.0 KB View Download
Screenshot_20170405-105546.png
99 KB View Download
One clue as to what's happening: on desktop, when you select an entity suggestion (by keying down) the correct text is displayed in the omnibox text field. Wherever that text is coming from we just need to also display it in the suggestion UI.
Labels: M-59

Comment 3 by k...@chromium.org, Apr 5 2017

Status: Started (was: Assigned)
So it turns out this is because what we considered to be incorrect behavior was actually chosen deliberately for the Android tablet UI. This was in order to match the behavior of the google.com desktop UI (see attached screenshot). The new platforms were getting assigned this behavior by the client-side parameter they were using.

However, in discussion with designers and Android Chrome folks, there was broad agreement that it would be better to use the Android phone UI (second screenshot in the original report) everywhere. This will allow us to remove the logic that distinguishes between these two cases, which is actually a surprising amount of code in GWS.
disambig.png
30.3 KB View Download
Cc: mard...@chromium.org
The "android chrome" version is a lot better than what we're doing now on iOS and desktop. Looks like the right decision to me. 
I agree with comment #5. 
Blocking: 690423
Wanted to check in on this bug, since I think it needs to be fixed before we get UI-review approval on the main launch bug https://bugs.chromium.org/p/chromium/issues/detail?id=690423.

Any update on the GWS side? If not that's okay.

Comment 8 by k...@chromium.org, Apr 28 2017

re: GWS, they said that the fix started showing up in data centers, but that there are some show-stoppers for wider distribution. ETA: couple days. (At least that's how I read it.) I checked on a dev-branch binary this morning and still saw the "raw" suggestion.
krb and I just discussed and it looks like there's still one more blocking issue preventing the new GWS from rolling out widely. Hopefully today or tomorrow the fix will be live.

Comment 10 by k...@chromium.org, May 1 2017

Status: Fixed (was: Started)
The correct results were showing up for jdonnelly@ earlier, and are showing up for me now, so I can't guarantee that they're live everywhere but are definitely rolling out.
Status: Verified (was: Fixed)
Verified on the latest chrome 59.0.3071.84 beta on iPhone7(10.2.1) and iPad Air2(10.2.1) with the following steps

1. Launch chrome and Open NTP
2. Enter text ron

Observed results: entity suggest displays the entity title.

Screenshot: https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpLVZndkQxUnMyaEU/view?usp=sharing

Sign in to add a comment