New issue
Advanced search Search tips

Issue 708696 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 707958



Sign in to add a comment

chromeos-base/authpolicy unittest fails to build with llvm-next

Project Member Reported by rahulchaudhry@chromium.org, Apr 5 2017

Issue description

When building with llvm-next, chromeos-base/authpolicy unittest build fails with "error: lambda capture 'apps' is not used [-Werror,-Wunused-lambda-capture]".

See logs here: https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/llvm_next_toolchain/builds/220/steps/UnitTest/logs/stdio

 
Owner: ljusten@chromium.org
This seems to be new code from https://chromium-review.googlesource.com/#/c/445899/

Status: Started (was: Untriaged)
Blocking: 707958
This is another blocker for llvm-next rebase.

The fix should be simple: Remove apps from lambda capture.

authpolicy-0.0.1-r295: ../../../../../../../../../mnt/host/source/src/platform2/authpolicy/authpolicy_unittest.cc:804:28: error: lambda capture 'apps' is not used [-Werror,-Wunused-lambda-capture]
authpolicy-0.0.1-r295:   validate_user_policy_ = [apps](const em::CloudPolicySettings& policy) {
CL:468847. Is there an equivalent warning for llvm? I hoped we enabled all warnings.
This warning is new with (or only detected by) the next version of llvm that the toolchain team is planning an upgrade to.
We test the llvm-next on some builders on a nightly basis to minimize surprises when it's time for upgrade.

Thanks for the quick fix.

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/253aa72fce05ff9e8b1ff7f6cc661b767f6a1113

commit 253aa72fce05ff9e8b1ff7f6cc661b767f6a1113
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 06 12:22:55 2017

authpolicy: Remove unused lambda capture

Broke llvm-next build.

BUG= chromium:708696 
TEST=Ran tests.

Change-Id: I47b813b66c670d791c460bcb0d11d5e31930e022
Reviewed-on: https://chromium-review.googlesource.com/468847
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/253aa72fce05ff9e8b1ff7f6cc661b767f6a1113/authpolicy/authpolicy_unittest.cc

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment