New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708692 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Refactor ShouldShowKeyboardToggle() used in Ash IME menus

Project Member Reported by tdander...@chromium.org, Apr 5 2017

Issue description

ImeMenuTray::ShouldShowKeyboardToggle() and TrayIME::ShouldShowKeyboardToggle() have identical implementations; consider a refactoring opportunity to eliminate duplicated code.

 

Comment 1 by vadimt@chromium.org, Nov 28 2017

Labels: Not-Touch-Friendly-Launcher
Status: Fixed (was: Assigned)
TrayIme doesn't seem to exist anymore and I only see one implementation of ShouldShowKeyboardToggle in the code base. I assume this is no longer the case.

Sign in to add a comment