New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708678 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Billing address dropdown should focus on the first address on Android

Project Member Reported by se...@chromium.org, Apr 5 2017

Issue description

it currently focuses on the last address.
 
Summary: Billing address dropdown should focus on the first address on Android (was: Billing address dropdown should focus on the first last on Android)

Comment 2 by se...@chromium.org, Apr 5 2017

Do we want to be scrolled up in all the cases?

For example, if the selected billing address is the last in the list, when we click on it do we still want to be scrolled up in which case we would not see the selected item?

I think we would want to scroll to top only if no address was selected.

WDYT?
No address selected: scroll to top.
An address is selected: scroll the selected address.

Comment 4 by se...@chromium.org, Apr 5 2017

How it was before
focus_on_last.jpg
554 KB View Download

Comment 5 by se...@chromium.org, Apr 5 2017

Video of new behavior, if no address was selected it autoselects the first one when you click on the dropdown, thus bringing us to the top of the list.


After.mp4
1.4 MB View Download

Comment 6 by se...@chromium.org, Apr 5 2017

Cc: bbergher@chromium.org
I like this one. Ship it! :-)
This makes sense, but why does it show as uppercase in the dropdown? Or is that a different address?
That's another bug that we have not been able to fix yet. Seb, can you
investigate?
I don't think it's a bug, or at least it looks like a feature? From what I can see, the selected address is in upper case. so if you already have a billing address selected when you click on the dropdown that one will be in ALL CAPS. I actually like it haha

What do you guys think? We can open a new bug to discuss more if you want.
The UX mocks don't have it, so it's a bug ;-). If you can figure it out, great! Otherwise, don't spend too much time on it.
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f3e9710e52b1e1ee73a1e48b3343d03230fb20d

commit 7f3e9710e52b1e1ee73a1e48b3343d03230fb20d
Author: sebsg <sebsg@chromium.org>
Date: Thu Apr 06 15:34:11 2017

[Payments] When no billing address is selected, focus on the first one.

Previously, it would focus on the last, scrolling down in the view.

Now it selects the first one when you open the view, so the focus is
at the top.

No change for when a billing address was already selected.

BUG= 708678 

Review-Url: https://codereview.chromium.org/2801063002
Cr-Commit-Position: refs/heads/master@{#462484}

[modify] https://crrev.com/7f3e9710e52b1e1ee73a1e48b3343d03230fb20d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java

Status: Fixed (was: Started)
Verified this issue on M59-59.0.3068.1 build, some of them billing address displayed in CAPS.

Testing screen shot
Screenshot_2017-04-11-13-02-44.png
201 KB View Download
The CAPS address is the currently selected one. It's a bug, but low priority. We will fix it eventually.
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment