Billing address dropdown should focus on the first address on Android |
||||
Issue descriptionit currently focuses on the last address.
,
Apr 5 2017
Do we want to be scrolled up in all the cases? For example, if the selected billing address is the last in the list, when we click on it do we still want to be scrolled up in which case we would not see the selected item? I think we would want to scroll to top only if no address was selected. WDYT?
,
Apr 5 2017
No address selected: scroll to top. An address is selected: scroll the selected address.
,
Apr 5 2017
How it was before
,
Apr 5 2017
Video of new behavior, if no address was selected it autoselects the first one when you click on the dropdown, thus bringing us to the top of the list.
,
Apr 5 2017
,
Apr 5 2017
I like this one. Ship it! :-)
,
Apr 6 2017
This makes sense, but why does it show as uppercase in the dropdown? Or is that a different address?
,
Apr 6 2017
That's another bug that we have not been able to fix yet. Seb, can you investigate?
,
Apr 6 2017
I don't think it's a bug, or at least it looks like a feature? From what I can see, the selected address is in upper case. so if you already have a billing address selected when you click on the dropdown that one will be in ALL CAPS. I actually like it haha What do you guys think? We can open a new bug to discuss more if you want.
,
Apr 6 2017
The UX mocks don't have it, so it's a bug ;-). If you can figure it out, great! Otherwise, don't spend too much time on it.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f3e9710e52b1e1ee73a1e48b3343d03230fb20d commit 7f3e9710e52b1e1ee73a1e48b3343d03230fb20d Author: sebsg <sebsg@chromium.org> Date: Thu Apr 06 15:34:11 2017 [Payments] When no billing address is selected, focus on the first one. Previously, it would focus on the last, scrolling down in the view. Now it selects the first one when you open the view, so the focus is at the top. No change for when a billing address was already selected. BUG= 708678 Review-Url: https://codereview.chromium.org/2801063002 Cr-Commit-Position: refs/heads/master@{#462484} [modify] https://crrev.com/7f3e9710e52b1e1ee73a1e48b3343d03230fb20d/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
,
Apr 6 2017
,
Apr 11 2017
Verified this issue on M59-59.0.3068.1 build, some of them billing address displayed in CAPS. Testing screen shot
,
Apr 11 2017
The CAPS address is the currently selected one. It's a bug, but low priority. We will fix it eventually.
,
Jun 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rouslan@chromium.org
, Apr 5 2017