New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708664 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

34.6% regression in system_health.common_mobile at 460332:460358

Project Member Reported by pmeenan@chromium.org, Apr 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=708664

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3NanvAoM


Bot(s) for this bug's original alert(s):

android-nexus5X
Cc: jochen@chromium.org
Owner: jochen@chromium.org

=== Auto-CCing suspected CL author jochen@chromium.org ===

Hi jochen@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : jochen
  Commit : 57c4423dceffc997459ae34640abdfc1f067cc2e
  Date   : Wed Mar 29 10:46:28 2017
  Subject: Use Referrer-Policy headers for CSS stylesheets

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : timeToFirstContentfulPaint_avg/browse_news/browse_news_qq
  Change       : 31.40% | 272.883740741 -> 358.566037037

Revision             Result                  N
chromium@460331      272.884 +- 50.78        6      good
chromium@460338      232.656 +- 90.92        6      good
chromium@460342      274.946 +- 98.047       6      good
chromium@460343      258.768 +- 133.44       9      good
chromium@460344      340.933 +- 107.853      9      bad       <--
chromium@460345      350.456 +- 49.4475      6      bad
chromium@460358      358.566 +- 24.9329      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.qq system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983134917572310064

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5049560629510144


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: ----
my CL only changes what object the referrer header is computed from, the computation itself doesn't change, so I don't see how this would impact any metric.

Comment 5 by jochen@chromium.org, Apr 10 2017

Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
actually, there was a bug in the header generation, let's see whether the graph changes now that the fix has landed.

Comment 6 by jochen@chromium.org, Apr 11 2017

Status: Fixed (was: Assigned)
yeah, graph is back to normal

Sign in to add a comment