New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708643 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-02-10
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.2%-11.2% regression in blink_perf.bindings at 461090:461200

Project Member Reported by pmeenan@chromium.org, Apr 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=708643

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3MjP_AoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnIS-xgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3J-NvQoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac11-air
chromium-rel-mac11-pro
win-high-dpi
Cc: petermarshall@chromium.org
Owner: petermarshall@chromium.org

=== Auto-CCing suspected CL author petermarshall@chromium.org ===

Hi petermarshall@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Peter Marshall
  Commit : a450c18544df40f7c7cbed206a7cdd1ed38853aa
  Date   : Fri Mar 31 10:37:57 2017
  Subject: [builtins] Copy array contents using JS in ConstructByArrayLike.

Bisect Details
  Configuration: mac_air_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : typed-array-construct-from-same-type/typed-array-construct-from-same-type
  Change       : 10.97% | 2093.27046923 -> 1863.67947112

Revision                           Result                  N
chromium@461103                    2093.27 +- 53.7094      6      good
chromium@461105                    1997.95 +- 87.5242      6      good
chromium@461106                    1981.79 +- 77.8411      6      good
chromium@461106,v8@42f285fcbb      2037.35 +- 31.367       6      good
chromium@461106,v8@a450c18544      1854.89 +- 18.9896      6      bad       <--
chromium@461106,v8@d6bd3ebaea      1862.19 +- 28.1733      6      bad
chromium@461106,v8@3f8b2aeb35      1859.06 +- 19.9415      6      bad
chromium@461107                    1812.23 +- 15.6662      6      bad
chromium@461110                    1827.39 +- 52.916       6      bad
chromium@461116                    1838.07 +- 62.3538      6      bad
chromium@461128                    1835.02 +- 71.9511      6      bad
chromium@461152                    1827.41 +- 26.1154      6      bad
chromium@461200                    1863.68 +- 44.1398      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983135164307149056

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5251826007408640


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Started (was: Untriaged)
Status: Fixed (was: Started)
Recovered this performance with a few CLs. Back to the same level now.

Sign in to add a comment