New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708642 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: 2017-09-26
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5%-16.1% regression in smoothness.top_25_smooth at 461104:461225

Project Member Reported by pmeenan@chromium.org, Apr 5 2017

Issue description

See the link to graphs below.
 
Cc: dtapu...@chromium.org
Owner: dtapu...@chromium.org

=== Auto-CCing suspected CL author dtapuska@chromium.org ===

Hi dtapuska@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : dtapuska
  Commit : 8ba8d7142ef4449775d3d75b6f17b80d24d07f77
  Date   : Fri Mar 31 15:51:25 2017
  Subject: Teach main thread event queue about closures.

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : frame_times/Docs  (1 open document tab)
  Change       : 9.19% | 16.7193060639 -> 18.2554373443

Revision             Result                    N
chromium@461120      16.7193 +- 0.0817808      6      good
chromium@461127      16.7271 +- 0.0710119      6      good
chromium@461131      16.7256 +- 0.0644714      6      good
chromium@461132      16.7125 +- 0.0461735      6      good
chromium@461133      17.871 +- 0.738598        6      bad       <--
chromium@461134      18.2445 +- 0.798914       6      bad
chromium@461147      18.2127 +- 0.44259        6      bad
chromium@461173      18.0416 +- 0.417807       6      bad
chromium@461225      18.2554 +- 0.439908       6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=Docs...1.open.document.tab. smoothness.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983135175106414896

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5844269299924992


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : dtapuska
  Commit : 8ba8d7142ef4449775d3d75b6f17b80d24d07f77
  Date   : Fri Mar 31 15:51:25 2017
  Subject: Teach main thread event queue about closures.

Bisect Details
  Configuration: mac_10_11_perf_bisect
  Benchmark    : smoothness.top_25_smooth
  Metric       : percentage_smooth/Docs  (1 open document tab)
  Change       : 11.17% | 64.1937533191 -> 57.021578938

Revision             Result                  N
chromium@461120      64.1938 +- 3.18708      6      good
chromium@461127      64.5134 +- 2.8486       6      good
chromium@461131      63.9998 +- 2.51101      6      good
chromium@461132      64.9975 +- 3.13602      6      good
chromium@461133      56.3167 +- 3.06496      6      bad       <--
chromium@461134      56.0172 +- 7.63995      6      bad
chromium@461147      56.7901 +- 5.00839      6      bad
chromium@461173      55.1883 +- 9.20544      6      bad
chromium@461225      57.0216 +- 9.07813      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=Docs...1.open.document.tab. smoothness.top_25_smooth

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983115256003756320

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5858952383823872


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Cc: vmi...@chromium.org tdres...@chromium.org
+vmiura, tdresser: looks like dtapuska missed this one and is OOO for a while. Any ideas on next steps?

Comment 8 by vmi...@chromium.org, Sep 15 2017

It looks like something recovered much of this regression in the 470481-470531  range.  I'm not sure what to do next, except re-raise it to dtapuska's attention when he gets back.

Comment 9 Deleted

NextAction: 2017-09-26
Status: WontFix (was: Assigned)
This has certainly recovered. My change no made sense why the bisect had found it.
The NextAction date has arrived: 2017-09-26

Sign in to add a comment