New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 708641 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.1%-9.9% regression in thread_times.tough_scrolling_cases at 461196:461229

Project Member Reported by pmeenan@chromium.org, Apr 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=708641

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgnIj87QsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg3LS5qgoM


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
android-webview-nexus6
Cc: chongz@chromium.org
Owner: chongz@chromium.org

=== Auto-CCing suspected CL author chongz@chromium.org ===

Hi chongz@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : chongz
  Commit : 232fbc4bc87a4c35ea8ab60e1f7ff8e4e8e14de5
  Date   : Fri Mar 31 20:14:35 2017
  Subject: Revert of Enable VsyncAlignedInput to Field Trial (patchset #1 id:40001 of https://codereview.chromium.org/2752363002/ )

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : thread_times.tough_scrolling_cases
  Metric       : thread_raster_cpu_time_per_frame/thread_raster_cpu_time_per_frame
  Change       : 6.01% | 9.21181407445 -> 9.76542163038

Revision             Result                   N
chromium@461195      9.21181 +- 0.498341      6      good
chromium@461200      9.09005 +- 0.473304      9      good
chromium@461201      9.1525 +- 0.559862       9      good
chromium@461202      9.81334 +- 1.01058       9      bad       <--
chromium@461204      9.71405 +- 0.805916      9      bad
chromium@461212      9.75844 +- 0.37514       6      bad
chromium@461229      9.76542 +- 0.423301      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.tough_scrolling_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8983135190724199312

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6449010358878208


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Apr 18 2017

Cc: benhenry@google.com
 Issue 712376  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Apr 20 2017

 Issue 712392  has been merged into this issue.
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.

Comment 7 by chongz@chromium.org, Jul 27 2017

Status: WontFix (was: Assigned)
This is actually a revert of my previous Field Trial which caused some regressions.

Mark as WontFix since the code has went back to the original state.

Sign in to add a comment