Issue metadata
Sign in to add a comment
|
12.3% regression in blink_perf.events at 461182:461305 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Apr 5 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8983135211159779952
,
Apr 5 2017
=== Auto-CCing suspected CL author sadrul@chromium.org === Hi sadrul@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : sadrul Commit : 74685881f39e33005f2ff9034479bda6da1c1463 Date : Sat Apr 01 01:33:43 2017 Subject: gpu: Fix running callback on IO thread. Bisect Details Configuration: winx64intel_perf_bisect Benchmark : blink_perf.events Metric : EventsDispatchingInShadowTrees/EventsDispatchingInShadowTrees Change : 2.73% | 25898.8559359 -> 25192.0187086 Revision Result N chromium@461181 25898.9 +- 144.745 6 good chromium@461243 26073.2 +- 253.485 6 good chromium@461274 25948.7 +- 147.537 6 good chromium@461290 25599.2 +- 234.82 6 good chromium@461298 25640.4 +- 172.719 6 good chromium@461300 25608.8 +- 135.751 6 good chromium@461301 25332.6 +- 91.8396 6 bad <-- chromium@461302 25118.9 +- 210.841 6 bad chromium@461305 25192.0 +- 495.944 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.events Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983135211159779952 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5862921470476288 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Apr 5 2017
That change should not affect the performance. I would say the bisect is wrong (how often is that the case?). Is it possible to re-run?
,
Apr 5 2017
Way more often than we'd like. I'll kick off a new bisect.
,
Apr 5 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8983126707146602272
,
Apr 5 2017
Nevermind, the reference build graph wasn't displayed by default and the reference build moved by the same amount at the same time (infrastructure change, not code issue). Sorry for the false alarm.
,
Apr 5 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : sadrul Commit : 74685881f39e33005f2ff9034479bda6da1c1463 Date : Sat Apr 01 01:33:43 2017 Subject: gpu: Fix running callback on IO thread. Bisect Details Configuration: winx64intel_perf_bisect Benchmark : blink_perf.events Metric : EventsDispatchingInShadowTrees/EventsDispatchingInShadowTrees Change : 2.34% | 26057.3393752 -> 25448.4862113 Revision Result N chromium@461181 26057.3 +- 203.725 6 good chromium@461243 25992.4 +- 159.494 6 good chromium@461274 25984.5 +- 207.539 6 good chromium@461290 25734.2 +- 205.883 6 good chromium@461298 25773.5 +- 206.409 6 good chromium@461300 25701.9 +- 245.804 6 good chromium@461301 25421.8 +- 127.89 6 bad <-- chromium@461302 25454.4 +- 140.687 6 bad chromium@461305 25448.5 +- 281.004 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.events Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8983126707146602272 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5893463855333376 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pmeenan@chromium.org
, Apr 5 2017