Chrome : iOS: Google Apps - Spaces app needs to be removed |
|||||||||||||||
Issue descriptionApp Version: 59.0.3062.0 iOS Version: 10.3 Device: iPad , iPhone 6 URL: NA Proposed Priority: P2 Found-in Label : found in m-59 Other applicable labels: Mobile>Intents, UI>Settings Steps to reproduce: 1. Launch the app 2. Tap on Settings 3. Tap on Google Apps 4. Tap on Spaces - Install Observed results: Notice that the Spaces app shows blank in App store Expected results: Remove Spaces from the list of Google Apps, since Spaces do not exists in Appstore Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: NA Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: yes/no, Safari: nA Bug reproducible on current stable build (App Version, iOS Version): Yes, 57.0.2987.137 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes Shared Auth bugs: Bug reproducible in SSO1/SSO2 apps? NA Autofill bugs: Bug reproducible on Chrome desktop? NA Type-bug-regression? No Link to image: https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mV0JpcThNNHkydnM/view https://drive.google.com/a/google.com/file/d/0BwSBFDzHIX-mRXhYMGNsbExYc1U/view
,
Apr 5 2017
,
Apr 5 2017
pkl@ could you please take a look.
,
Apr 6 2017
This can be a 2-step process: 1. Revert https://chromereviews.googleplex.com/426447013/ - There's a good chance that this can be applied cleanly. 2. Remove Spaces from IntentsKit configuration, but that should probably be done by someone on the Spaces team responsible for unwinding the code. +cc: shalinisah
,
Apr 10 2017
Any update pkl? I am fine with the proposed 2-step process.
,
Apr 10 2017
Thanks Peter! I will send out a CL to cleanup Spaces from IntentsKit configuration.
,
Apr 10 2017
I have sent http://cl/152730818 to remove Spaces from IntentsKit configuration.
,
Apr 10 2017
,
Apr 10 2017
+jasonkliu as FYI
,
Apr 11 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/ea2646115eab9730076d45fbc7d215da48e38767 commit ea2646115eab9730076d45fbc7d215da48e38767 Author: pkl <pkl@google.com> Date: Tue Apr 11 09:08:41 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a18f1349f3a93817a44f6a5cdca13aca485a2df7 commit a18f1349f3a93817a44f6a5cdca13aca485a2df7 Author: pkl <pkl@chromium.org> Date: Tue Apr 11 09:26:57 2017 Removes constant for Google Spaces app This is part of the revert of https://chromereviews.googleplex.com/426447013/ This CL depends on https://chromereviews.googleplex.com/578437015 and should not be submitted until it has been submitted. BUG= 708607 TEST=Go to Settings and check that Google Spaces is no longer listed. Review-Url: https://codereview.chromium.org/2809853002 Cr-Commit-Position: refs/heads/master@{#463587} [modify] https://crrev.com/a18f1349f3a93817a44f6a5cdca13aca485a2df7/ios/chrome/browser/native_app_launcher/ios_appstore_ids.h [modify] https://crrev.com/a18f1349f3a93817a44f6a5cdca13aca485a2df7/ios/chrome/browser/native_app_launcher/ios_appstore_ids.mm
,
Apr 11 2017
,
Apr 11 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
,
Apr 11 2017
,
Apr 11 2017
This bug requires manual review: Less than 10 days to go before AppStore submit on M58 Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 12 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e72df852ced973b21934ce404957bef913feec6b commit e72df852ced973b21934ce404957bef913feec6b Author: pkl <pkl@google.com> Date: Wed Apr 12 17:22:36 2017
,
Apr 12 2017
,
Apr 12 2017
,
Apr 17 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2017
Already merged. See comment 16.
,
Apr 18 2017
Tested in the latest M59.0.3069.0 canary on iPhone 7(iOS 10.2.1) and iPad mini(iOS 9.3.5). The issue is resolved, the spaces app has been removed from the list of the google apps.
,
Apr 19 2017
Tested in the latest M58.0.3029.82 on iPhone 6s(iOS 10.3.1) and iPad pro(iOS 9.3.5). The issue is resolved, the spaces app has been removed from the list of the google apps. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by jdhakshinamoor@chromium.org
, Apr 5 2017Labels: -Pri-3 iOS ChromeiOS Pri-2